[asterisk-bugs] [Asterisk 0015032]: [patch] Sign problem calculating timestamp for iax frame leads to no audio on the receiving peer.

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15032 
====================================================================== 
Reported By:                guillecabeza
Assigned To:                dvossel
====================================================================== 
Project:                    Asterisk
Issue ID:                   15032
Category:                   Channels/chan_iax2
Reproducibility:            sometimes
Severity:                   major
Priority:                   normal
Status:                     closed
Asterisk Version:           Older 1.4 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-05-04 17:34 CDT
Last Modified:              2009-05-21 14:13 CDT
====================================================================== 
Summary:                    [patch] Sign problem calculating timestamp for iax
frame leads to no audio on the receiving peer.
Description: 
There's a case when as seen from this log:

Tx-Frame Retry[000] -- OSeqno: 001 ISeqno: 003 Type: VOICE   Subclass:
136
   Timestamp: 4294967271ms  SCall: 00006  DCall: 14259
[192.168.20.199:4569]

The timestamp gets calculated wrong(due to a sign problem) resulting in
all sorts of audio problems on the other side(when dealing with jitter
buffer historic timestamps and you know the story).

====================================================================== 

---------------------------------------------------------------------- 
 (0105256) svnbot (reporter) - 2009-05-21 14:13
 https://issues.asterisk.org/view.php?id=15032#c105256 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 195998

_U  branches/1.6.1/
U   branches/1.6.1/channels/chan_iax2.c

------------------------------------------------------------------------
r195998 | dvossel | 2009-05-21 14:13:45 -0500 (Thu, 21 May 2009) | 27
lines

Merged revisions 195995 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

................
  r195995 | dvossel | 2009-05-21 14:11:49 -0500 (Thu, 21 May 2009) | 20
lines
  
  Merged revisions 195991 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r195991 | dvossel | 2009-05-21 14:04:56 -0500 (Thu, 21 May 2009) | 14
lines
    
    Sign problem calculating timestamp for iax frame leads to no audio on
the receiving peer.
    
    There are rare cases in which a frame's delivery timestamp is slightly
less than the iax2_pvt's offset.  This causes the pvt's timestamp to be a
small negative number, but since the timestamp value is unsigned it looks
like a huge positive number.  This patch checks for this negative case and
sets the ms to zero.  A similar check is already done right below this one
in the 'else' statement.
    
    (closes issue https://issues.asterisk.org/view.php?id=15032)
    Reported by: guillecabeza
    Patches:
          chan_iax2.c.patch_timestamp uploaded by guillecabeza (license
380)
    Tested by: guillecabeza
    
    (closes issue https://issues.asterisk.org/view.php?id=14216)
    Reported by: Andrey Sofronov
  ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=195998 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-05-21 14:13 svnbot         Checkin                                      
2009-05-21 14:13 svnbot         Note Added: 0105256                          
======================================================================