[asterisk-bugs] [Asterisk 0015157]: Annoying "Unknown RTP codec 126 received" messages confuse people

[Asterisk Bug Tracker]

The following issue has been REOPENED. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15157 
====================================================================== 
Reported By:                jcovert
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   15157
Category:                   Core/RTP
Reproducibility:            always
Severity:                   tweak
Priority:                   normal
Status:                     new
Asterisk Version:           1.6.0.9 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-05-19 12:51 CDT
Last Modified:              2009-05-21 11:58 CDT
====================================================================== 
Summary:                    Annoying "Unknown RTP codec 126 received" messages
confuse people
Description: 
The X-Lite Softphone, one of the most commonly used softphones on Asterisk,
sends RTP codec 126 messages, which annoy and confuse users who are running
with verbosity set to 3, the most likely verbosity setting for watching a
system in operation.

I propose:

a. modifying main/rtp.c to test VERBOSITY_ATLEAST(4) prior to the call to
ast_log(LOG_NOTICE, "Unknown RTP codec %d received from...",...)

b. (and/or possibly) explicitly ignoring 126 no matter what the
verbosity.

I will generate a patch in the next two or three days; in the interim I
welcome any comments.

I also note that in trunk rtp.c has been replaced by rtp_engine.c; I have
not yet determined whether a similar issue exists.  Comments?

Regards/john
====================================================================== 

---------------------------------------------------------------------- 
 (0105239) jcovert (reporter) - 2009-05-21 11:58
 https://issues.asterisk.org/view.php?id=15157#c105239 
---------------------------------------------------------------------- 
Sorry, Leif and Brian, but the RTP spec (RFC 3550) clearly says that the
receiver is to ignore any RTP payload types which it does not understand.

in order to comply with the RTP spec, the NOTICE needs to be removed or at
least changed to a DEBUG.

I am attaching a tested patch which removes the NOTICE.

5. RTP Data Transfer Protocol

5.1 RTP Fixed Header Fields

...

payload type (PT): 7 bits
This field identifies the format of the RTP payload and determines
its interpretation by the application. A profile MAY specify a
default static mapping of payload type codes to payload formats.
Additional payload type codes MAY be defined dynamically through
non-RTP means (see Section 3). A set of default mappings for
audio and video is specified in the companion RFC 3551 [1]. An
RTP source MAY change the payload type during a session, but this
field SHOULD NOT be used for multiplexing separate media streams
(see Section 5.2).

A receiver MUST ignore packets with payload types that it does not
understand.

Thank you/john 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-05-21 11:58 jcovert        Note Added: 0105239                          
2009-05-21 11:58 jcovert        Status                   closed => new       
2009-05-21 11:58 jcovert        Resolution               no change required =>
reopened
======================================================================