[asterisk-bugs] [Asterisk 0012779]: [patch] smsq does not work in asterisk 1.6

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=12779 
====================================================================== 
Reported By:                PH
Assigned To:                dvossel
====================================================================== 
Project:                    Asterisk
Issue ID:                   12779
Category:                   Applications/app_sms
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     feedback
Target Version:             1.6.2.0
Asterisk Version:           SVN 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2008-06-03 06:53 CDT
Last Modified:              2009-05-20 14:30 CDT
====================================================================== 
Summary:                    [patch] smsq does not work in asterisk 1.6
Description: 
smsq which works well in asterisk 1.4, does not work
in the same way on 1.6 :

  -- Attempting call on mISDN/1/0809101000 for application SMS(0) (Retry
1)
       > Channel mISDN/1-u5 was answered.
       > Launching SMS(0) on mISDN/1-u5
 sms argc 1 queue <0> opts <> addr <> body <>
 initial delay 300ms
    -- SMS RX 93 00 6D
    -- SMS TX 91 16 01 01 0A 81 60 70 47 90 10 00 F1 0B E8 32 9B FD 06
DD DF 72 36 19
    -- SMS RX 95 09 01 00 80 50 62 90 71 32 80 7C
    -- SMS TX 94 00
[May 26 09:37:30] NOTICE[6747]: app_sms.c:1904 sms_exec: ast_read failed
[May 26 09:37:30] NOTICE[6747]: pbx_spool.c:333 attempt_thread: Call
completed to mISDN/1/0809101000


====================================================================== 

---------------------------------------------------------------------- 
 (0105143) BMC (reporter) - 2009-05-20 14:30
 https://issues.asterisk.org/view.php?id=12779#c105143 
---------------------------------------------------------------------- 
What I don't understand:
In 1.4.x app_sms.c was written by Adrian Kennard and it was working fine.
Beginning with 1.6.x app_sms.c was modified by Filippo Grassilli:

 * \author Adrian Kennard (for the original protocol 1 code)
 * \author Filippo Grassilli (Hyppo) - protocol 2 support
 *		   Not fully tested, under development
===================^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^==============

Therefore I think you have two options:
1. Go back to the working code of Adrian Kennard
2. Contact Filippo Grassilli to help us debugging.
He marks the code "not fully tested" - therefore it should not be
implemented in a production version!

If more debugging code is added I can test the result with my hardware.
Unfortunately I don't understand the code so it is very difficult for me
to add the code which is necessary for debugging.... 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-05-20 14:30 BMC            Note Added: 0105143                          
======================================================================