[asterisk-bugs] [Asterisk 0015121]: [patch] Video support in SIP channel driver appears to be totally broken

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15121 
====================================================================== 
Reported By:                jsmith
Assigned To:                lmadsen
====================================================================== 
Project:                    Asterisk
Issue ID:                   15121
Category:                   Channels/chan_sip/Video
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
Regression:                 Yes 
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.1 
SVN Revision (number only!): 194542 
Request Review:              
====================================================================== 
Date Submitted:             2009-05-15 11:52 CDT
Last Modified:              2009-05-19 11:20 CDT
====================================================================== 
Summary:                    [patch] Video support in SIP channel driver appears
to be totally broken
Description: 
I'm unable to get video working at all in either the 1.6.0 or 1.6.1
branches (latest SVN).
====================================================================== 

---------------------------------------------------------------------- 
 (0105016) jsmith (administrator) - 2009-05-19 11:20
 https://issues.asterisk.org/view.php?id=15121#c105016 
---------------------------------------------------------------------- 
OK, so it appears my patch a bit hackish... let me explain why.

The reason why the RTP port was getting set to 0 was that the "needvideo"
variable is being set in line 8352, but we're using its value before that
in the call to get_our_media_address in line 8325.  My patch
short-circuited the logic, but I think the real way to fix this will be to
move the logic around the "needvideo" variable above the call to
get_our_media_address.

I'll work on another (less hackish) patch. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-05-19 11:20 jsmith         Note Added: 0105016                          
======================================================================