[asterisk-bugs] [Asterisk 0013797]: [patch] forkcdr() doesn't fork when call disposition is ANSWERED

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=13797 
====================================================================== 
Reported By:                sh0t
Assigned To:                mnicholson
====================================================================== 
Project:                    Asterisk
Issue ID:                   13797
Category:                   Applications/app_forkcdr
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.4.22 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2008-10-29 08:59 CDT
Last Modified:              2009-05-15 16:06 CDT
====================================================================== 
Summary:                    [patch] forkcdr() doesn't fork when call disposition
is ANSWERED
Description: 
Hello, I have problem with forkcdr app. (sip-sip calls)
First look at this sample dialplan

exten => s,1,answer
exten => s,n,Set(CDR(accountcode)=1001)
exten => s,n,Set(CDR(userfield)=MAIN)
exten => s,n,wait(2)
exten => s,n,ForkCDR()
exten => s,n,ResetCDR()
exten => s,n,Set(CDR(userfield)=OUTpggw1)
exten => s,n,Dial(SIP/pggw1,20)
exten => s,n,hangup

Everything works ok when that Dial result is NO ANSWER or for example
FAILED
but if I answer that call. I will see only one CDR record (that with
userfield MAIN)

(the failure scenario (with answered call))
bellow two examples of the cdr records (stored in pgsql database)
2008-10-29
14:17:58,32,32,11,pg-gw,SIP/pggw2-c8073fd0,,Dial,SIP/pggw1|20,14,6,ANSWERED,3,1001,1225286278.17290,MAIN

(the expected one, only when call disposition is NO ANSWER or billsec=0)
2008-10-29
14:19:03,32,32,11,pg-gw,SIP/pggw2-c807dd30,,ForkCDR,,10,10,ANSWERED,3,1001,1225286343.17309,MAIN
2008-10-29
14:19:05,32,32,s,test1,SIP/pggw2-c807dd30,SIP/pggw1-01139f40,Dial,SIP/pggw1|20,8,0,NO
ANSWER,3,1001,1225286343.17309,OUTpggw1

I'm using forkcdr because I need to have two cdr records. One for
incomiing call and one for that dial.

It worked for a long time with earlier versions of asterisk (for example
1.4.11)

======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0013881 [patch] AGI command "answer" ...
====================================================================== 

---------------------------------------------------------------------- 
 (0104849) mnicholson (administrator) - 2009-05-15 16:06
 https://issues.asterisk.org/view.php?id=13797#c104849 
---------------------------------------------------------------------- 
I think I have found and fixed the remaining issues with answer time here. 
Test the attached patch.  With ForkCDR() the answer times should be the
same, but with ForkCDR(A) the answer times should be different (and
correct).

Please test and let if my patch works correctly. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-05-15 16:06 mnicholson     Note Added: 0104849                          
======================================================================