[asterisk-bugs] [Asterisk 0014460]: Asterisk plays a continuous tone forever if it never receives a 2833 end packet

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=14460 
====================================================================== 
Reported By:                moliveras
Assigned To:                file
====================================================================== 
Project:                    Asterisk
Issue ID:                   14460
Category:                   Core/RTP
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           1.4.21.1 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-02-11 14:46 CST
Last Modified:              2009-05-13 08:39 CDT
====================================================================== 
Summary:                    Asterisk plays a continuous tone forever if it never
receives a 2833 end packet
Description: 
I am running asterisk 1.4.21.1, but have also reproduced this issue with
1.6.1-rc1.

Asterisk is bridging a call between two endpoints, both using rfc2833 for
digit detection.

SBC (192.168.196.40) --> asterisk (192.168.196.33) --> IP Phone
(192.168.196.181).

Asterisk receives a single rfc2833 digit with a duration of 320 (no end
packet) from 196.40.  Asterisk then sends a continuous stream of 2833
events towards the other end with increasing duration, causing a continuous
tone to be played.  Asterisk also stops sending rtp towards 196.181 while
sending the 2833 events.

I believe that this is not compliant with rfc2833.

Would it be better if the 2833 packets were simply forwarded on if
bridging between two peers that both do 2833?  At least the tone should not
last forever, and should not block rtp.   This 2833 packet originated from
an Adtran TA904 gateway that falsely detected a digit when none was pressed
(talk off).

I will attach a packet capture after submitting this ticket.

======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0014815 [patch] DTMF Appears to be broken from ...
====================================================================== 

---------------------------------------------------------------------- 
 (0104674) svnbot (reporter) - 2009-05-13 08:39
 https://issues.asterisk.org/view.php?id=14460#c104674 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 194209

_U  trunk/
U   trunk/res/res_rtp_asterisk.c

------------------------------------------------------------------------
r194209 | file | 2009-05-13 08:39:15 -0500 (Wed, 13 May 2009) | 18 lines

Merged revisions 194208 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r194208 | file | 2009-05-13 10:38:01 -0300 (Wed, 13 May 2009) | 11 lines
  
  Fix RFC2833 issues with DTMF getting duplicated and with duration
wrapping over.
  
  (closes issue https://issues.asterisk.org/view.php?id=14815)
  Reported by: geoff2010
  Patches:
        v1-14815.patch uploaded by dimas (license 88)
  Tested by: geoff2010, file, dimas, ZX81, moliveras
  (closes issue https://issues.asterisk.org/view.php?id=14460)
  Reported by: moliveras
  Tested by: moliveras
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=194209 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-05-13 08:39 svnbot         Checkin                                      
2009-05-13 08:39 svnbot         Note Added: 0104674                          
======================================================================