[asterisk-bugs] [Asterisk 0013691]: [patch] Unanswered Queue() calls don't have CDR

Tue May 12 18:04:04 CDT 2009

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=13691 
====================================================================== 
Reported By:                dferrer
Assigned To:                mnicholson
====================================================================== 
Project:                    Asterisk
Issue ID:                   13691
Category:                   CDR/NewFeature
Reproducibility:            N/A
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           1.4.22 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 148867 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2008-10-14 11:15 CDT
Last Modified:              2009-05-12 18:04 CDT
====================================================================== 
Summary:                    [patch] Unanswered Queue() calls don't have CDR
Description: 
When a call goes to Queue app without an Answer in its path, and call
doesn't get answered, there is no CDR for this call. The first impression
is that this appears to be a correct behaviour, because I've option
"unanswered=no" in cdr.conf. 
However this 'unanswered' is a bit incoherent, because if I dial B using
Dial app, and B doesn't answer, CDR is posted in this case (field 'channel'
and 'dstchannel' have source and destination channels in this case, so CDR
is posted). For the Queue case, 'dstchannel' is empty, so CDR post is
disabled, as you can see in post_cdr logic to skip unanswered calls.

I'm happy with current behaviour, but I wanted to change it for Queue
calls: I wanted a CDR posted in case of a missed Queue call. I'm attaching
a patch for 1.4.22 and trunk for app_queue for that, I mark CDR as
AST_CDR_FLAG_DONT_TOUCH and in post_cdr it will be "untouched" if cdr is
marked with this flag. Another solution was to put Queue's final
destination channel in 'dstchannel', but this is not elegant when I'm in
'ringall' strategy.

======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0013892 After upgrading from 1.4.21.2 to 1.4.22...
parent of           0013637 Missing userfield for Queue call with N...
====================================================================== 

---------------------------------------------------------------------- 
 (0104644) svnbot (reporter) - 2009-05-12 18:04
 https://issues.asterisk.org/view.php?id=13691#c104644 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 194063

_U  branches/1.6.0/
U   branches/1.6.0/apps/app_queue.c

------------------------------------------------------------------------
r194063 | mnicholson | 2009-05-12 18:04:02 -0500 (Tue, 12 May 2009) | 29
lines

Merged revisions 194057 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

................
  r194057 | mnicholson | 2009-05-12 17:32:13 -0500 (Tue, 12 May 2009) | 22
lines

  Merged revisions 194028 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4

  ........
    r194028 | mnicholson | 2009-05-12 17:15:45 -0500 (Tue, 12 May 2009) |
16 lines

    This change modifies app_queue to properly generate CDR records in
failure
    situations.

    This involves setting a proper cdr disposition coresponding to the
given
    failure condition and ensuring the proper information is stored in the
cdr
    record.

    (closes issue https://issues.asterisk.org/view.php?id=13691)
    Reported by: dferrer
    Tested by: mnicholson

    (closes issue https://issues.asterisk.org/view.php?id=13637)
    Reported by: atis
    Tested by: atis
  ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=194063 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-05-12 18:04 svnbot         Checkin                                      
2009-05-12 18:04 svnbot         Note Added: 0104644                          
======================================================================