[asterisk-bugs] [Asterisk 0015088]: [patch] Asterisk crash when logging out from a manager session.

Asterisk Bug Tracker noreply at bugs.digium.com
Tue May 12 17:49:21 CDT 2009


A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15088 
====================================================================== 
Reported By:                eliel
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   15088
Category:                   Core/ManagerInterface
Reproducibility:            have not tried
Severity:                   crash
Priority:                   normal
Status:                     new
Asterisk Version:           SVN 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 193868 
Request Review:              
====================================================================== 
Date Submitted:             2009-05-12 10:27 CDT
Last Modified:              2009-05-12 17:49 CDT
====================================================================== 
Summary:                    [patch] Asterisk crash when logging out from a
manager session.
Description: 
How to reproduce:

1) Login to the asterisk manager.
2) Logout from the asterisk manager.
3) Asterisk crashed.

======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0014974 [patch] erros messages astobj2.c INTERN...
====================================================================== 

---------------------------------------------------------------------- 
 (0104641) svnbot (reporter) - 2009-05-12 17:49
 https://issues.asterisk.org/view.php?id=15088#c104641 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 194060

U   trunk/main/manager.c

------------------------------------------------------------------------
r194060 | eliel | 2009-05-12 17:49:18 -0500 (Tue, 12 May 2009) | 22 lines

Fix a crash when logging out from the AMI and avoid astobj2 warning
messages.

When the user logout the session was being destroyed twice and the file
descriptor was being closed twice. The sessions reference counter wasn't
used in a proper way.
The 'mansession' structure was being treated as an astobj2 and we were
calling ao2_lock/ao2_unlock causing astobj2 report a warning message and
not locking the structure.
Also we were using an ugly naming convention 'destroy_session',
'session_destroy', 'free_session', ... all this "duplicated" code was
merged.

(closes issue https://issues.asterisk.org/view.php?id=14974)
Reported by: pj
Patches:
      manager.diff2 uploaded by eliel (license 64)
      Tested by: dhubbard, eliel, mnicholson

(closes issue https://issues.asterisk.org/view.php?id=15088)
Reported by: eliel

Review: http://reviewboard.asterisk.org/r/248/

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=194060 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-05-12 17:49 svnbot         Checkin                                      
2009-05-12 17:49 svnbot         Note Added: 0104641                          
======================================================================




More information about the asterisk-bugs mailing list