[asterisk-bugs] [Asterisk 0014446]: [patch] chan_sip does not support the maddr attribute in Via headers

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14446 
====================================================================== 
Reported By:                frawd
Assigned To:                oej
====================================================================== 
Project:                    Asterisk
Issue ID:                   14446
Category:                   Channels/chan_sip/Interoperability
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.4.23 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-02-10 04:12 CST
Last Modified:              2009-05-09 13:25 CDT
====================================================================== 
Summary:                    [patch] chan_sip does not support the maddr
attribute in Via headers
Description: 
I recently connected Asterisk with a badly configured Nortel CS2K, which
sends me the following Via header:

Via: SIP/2.0/UDP
CS2KSSTEMAG:5060;maddr=213.60.204.48;branch=z9hG4bK-142abd7-ec6f41f2-4aeebdaf

CS2KSSTEMAG not being a valid DNS entry, the reply is never sent (Asterisk
blocks trying to resolve the name). Even tho it is a configuration error,
maddr should be used as reply address.

The attached patch fixes the issue in 1.4.23.1
====================================================================== 

---------------------------------------------------------------------- 
 (0104509) frawd (reporter) - 2009-05-09 13:25
 http://bugs.digium.com/view.php?id=14446#c104509 
---------------------------------------------------------------------- 
Except if I'm totally wrong about that Via thing (eoj, you mentioned those
headers were not meant for UAS?), I think the patch is valid.

Another issue would be what ibc mentioned, that if the "sent-by" contains
a hostname, or an IP that differs from the packet's SOURCE_IP, * should
reply to the SOURCE_IP, placing a ";received=SOURCE_IP" to the Via (I think
* already places a "received=" whatever happens).

This last issue is not what that bug was initially about, but I'm willing
to make a patch if someone opens a new bug. My priority being to get this
first patch included if it is really valid. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-05-09 13:25 frawd          Note Added: 0104509                          
======================================================================