[asterisk-bugs] [Asterisk 0015068]: [patch] Add Queue Reset ability to Reset all members and all Numbers

Asterisk Bug Tracker noreply at bugs.digium.com
Fri May 8 14:39:34 CDT 2009


A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=15068 
====================================================================== 
Reported By:                sum
Assigned To:                mmichelson
====================================================================== 
Project:                    Asterisk
Issue ID:                   15068
Category:                   Applications/app_queue
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.6.2.0-beta1 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.2 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-05-08 09:13 CDT
Last Modified:              2009-05-08 14:39 CDT
====================================================================== 
Summary:                    [patch] Add Queue Reset ability to Reset all members
and all Numbers
Description: 
When you reset a queue there are few things are not reset and are important
to get the numbers consistent.
talktime and the statics of the members of the queue.
====================================================================== 

---------------------------------------------------------------------- 
 (0104487) mmichelson (administrator) - 2009-05-08 14:39
 http://bugs.digium.com/view.php?id=15068#c104487 
---------------------------------------------------------------------- 
Hi sum, thanks for the patch.

Your patch accomplishes what needs to be done, but there are a few tweaks
that need to be made.

1. The coding guidelines state that lines should be indented with tabs,
not spaces.

2. The coding guidelines recommend that you use curly braces to enclose
the body of while/for/if/do blocks even if the body is only one line.

3. You need to be sure to decrement the reference count of mem every time
through the while loop.

4. Trailing whitespace is discouraged.

Since this is all very minor, and I know you've been trying to get this
functionality in for a while, I can make the necessary adjustments when
committing the change. Thanks for the patch! 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-05-08 14:39 mmichelson     Note Added: 0104487                          
======================================================================




More information about the asterisk-bugs mailing list