[asterisk-bugs] [Asterisk 0014385]: Unhold fails if first SDP on OK, particularly Cisco CCM 6

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14385 
====================================================================== 
Reported By:                davidw
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   14385
Category:                   Channels/chan_sip/Interoperability
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     new
Asterisk Version:           1.6.0.1 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-02-02 06:39 CST
Last Modified:              2009-05-08 11:12 CDT
====================================================================== 
Summary:                    Unhold fails if first SDP on OK, particularly Cisco
CCM 6
Description: 
Cisco CCM 6 appears never to send SDP on the INVITE, so Asterisk
effectively makes the offer, even when the Cisco is re-inviting because a
CCM hosted phone has gone on hold.  Asterisk sets up its SDP from flags[1]
in the channel private data structure, which means that, if the channel was
on hold, it will offer a=inactive (observed, although a=recvonly also seems
possible).  Even if the CCM intended to unhold, the only possible response
to an a=inactive offer, is a=inactive.  Asterisk should only actually use
saved state if it is making the response.  For an offer, as it looks like
it can never locally hold, it should offer a=sendrecv.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0014448 [patch] chan_sip fails to remove hold w...
====================================================================== 

---------------------------------------------------------------------- 
 (0104468) davidw (reporter) - 2009-05-08 11:12
 http://bugs.digium.com/view.php?id=14385#c104468 
---------------------------------------------------------------------- 
On further consideration, there is too much fiddling to apply the changes
in sequence, so I've eliminated 65401 and instead applied just 174644,
inlining the relevant bit of change_hold_state.

Specifically, I've used the current version of the debug output code, and
copied the history, event, notify and flag clearing code from the code that
deals with SDP with a null IP address.

Now to see if it works. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-05-08 11:12 davidw         Note Added: 0104468                          
======================================================================