[asterisk-bugs] [Asterisk 0015036]: [patch] ignore both DTMF BEGIN and END from RTP when not in RFC2833 mode

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=15036 
====================================================================== 
Reported By:                dimas
Assigned To:                file
====================================================================== 
Project:                    Asterisk
Issue ID:                   15036
Category:                   Channels/chan_sip/General
Reproducibility:            have not tried
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           1.4.24 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-05-05 12:33 CDT
Last Modified:              2009-05-06 08:36 CDT
====================================================================== 
Summary:                    [patch] ignore both DTMF BEGIN and END from RTP when
not in RFC2833 mode
Description: 
I encountered this issue helping with 14815.
There is a code in chan_sip which drops AST_FRAME_DTMF frames coming from
ast_rtp_read if the dtmfmode is not RFC2833.
The problem is that only end frame is ignored while begin frame is still
passed to the core of Asterisk causing various effects like continuous
tone.

The patch makes behavior more consistent by dropping begin frames as well.
It also logs debug message to let easier troubleshooting.
====================================================================== 

---------------------------------------------------------------------- 
 (0104291) svnbot (reporter) - 2009-05-06 08:36
 http://bugs.digium.com/view.php?id=15036#c104291 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 192635

_U  branches/1.6.0/
U   branches/1.6.0/channels/chan_sip.c

------------------------------------------------------------------------
r192635 | file | 2009-05-06 08:36:20 -0500 (Wed, 06 May 2009) | 21 lines

Merged revisions 192634 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

................
  r192634 | file | 2009-05-06 10:34:35 -0300 (Wed, 06 May 2009) | 14 lines
  
  Merged revisions 192633 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r192633 | file | 2009-05-06 10:30:51 -0300 (Wed, 06 May 2009) | 7
lines
    
    Update some old logic to stop both begin and end DTMF frames from
reaching the core if rfc2833 is not enabled.
    
    (closes issue http://bugs.digium.com/view.php?id=15036)
    Reported by: dimas
    Patches:
          v1-15036.patch uploaded by dimas (license 88)
  ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=192635 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-05-06 08:36 svnbot         Checkin                                      
2009-05-06 08:36 svnbot         Note Added: 0104291                          
======================================================================