[asterisk-bugs] [Asterisk 0015025]: [patch] Functions INC and DEC
Asterisk Bug Tracker
noreply at bugs.digium.com
Tue May 5 04:58:03 CDT 2009
A NOTE has been added to this issue.
======================================================================
http://bugs.digium.com/view.php?id=15025
======================================================================
Reported By: greenfieldtech
Assigned To:
======================================================================
Project: Asterisk
Issue ID: 15025
Category: Functions/func_math
Reproducibility: N/A
Severity: feature
Priority: normal
Status: new
Asterisk Version: SVN
Regression: No
SVN Branch (only for SVN checkouts, not tarball releases): trunk
SVN Revision (number only!): 191919M
Request Review:
======================================================================
Date Submitted: 2009-05-03 20:30 CDT
Last Modified: 2009-05-05 04:58 CDT
======================================================================
Summary: [patch] Functions INC and DEC
Description:
Over the course of time, developing Asterisk dialplans becomes fairly
cumbersome, especially when writing While() loops in the dialplan. Mainly,
when we want to iterate a few times, the ever annoying Set(Var=$[${Var} +
1]) is really annoying.
INCrement and DECrement follow the old PASCAL functions, allowing to
increment and decrement a variable.
The functions are built to handle both numeric and alpha-numeric values.
If an alpha-numeric value is given, the functions will simply bail out and
issue a LOG_NOTICE accordingly.
In order to implement this, i've added some functionality to func_math.c
and added a new ast_is_numeric function to strings.h
Please find attached patches for TRUNK.
======================================================================
----------------------------------------------------------------------
(0104194) atis (reporter) - 2009-05-05 04:58
http://bugs.digium.com/view.php?id=15025#c104194
----------------------------------------------------------------------
It seems that You're using some bad editor, as there are some spacing
changes.
You can do diff -w to ignore whitespace changes :)
Also, i would suggest not using MyVar in doc, but something in lowercase -
like <variable>, and the same name in syntax warning (of which i'm still
not sure that it should be warning :)
Btw, looking at the code of ast_is_numeric - does this work with negative
numbers? Are numbers >2^31 allowed in dialplan variables? If not, i would
go with simpler checking.
Issue History
Date Modified Username Field Change
======================================================================
2009-05-05 04:58 atis Note Added: 0104194
======================================================================
More information about the asterisk-bugs
mailing list