[asterisk-bugs] [Asterisk 0014504]: [patch] Allow app_dial to provide 'tone while ringing' like 'option m' which will provide 'music on hold while dialling'

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14504 
====================================================================== 
Reported By:                alecdavis
Assigned To:                tilghman
====================================================================== 
Project:                    Asterisk
Issue ID:                   14504
Category:                   Applications/NewFeature
Reproducibility:            always
Severity:                   feature
Priority:                   normal
Status:                     ready for review
Asterisk Version:           SVN 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-02-19 05:23 CST
Last Modified:              2009-05-04 15:26 CDT
====================================================================== 
Summary:                    [patch] Allow app_dial to provide 'tone while
ringing' like 'option m' which will provide 'music on hold while dialling'
Description: 
Application is to allow asterisk to be an ISDN providered to attempt
delivery of calls over Cellular Trunks connected to asterisk, if it cannot
deliver the call then signal CONGESTION to the calling party switch, who
will then respond appropriately by delivering the call out over its PSTN
connection.

Currently this can be achived, with option 'm([classs])' in the dial
command, which will indicate PROGRESS to the calling party and provide moh.
But it's just not right to play music as a ring tone.

option 'r' from app_dial indicates 'RINGING' to the calling party, which
is fine if you don't then what to indicate CONGESTION.  Because the calling
party's switch already believes asterisk can deliver the call, it won't try
an alternative.

The patch I have provided doesn't change the default functionality of
option 'r' but adds to it.
Like option 'm', which will play a 'class' of music as defined in
musiconhold.conf, option 'r' will play a 'tone' as defined in
indications.conf, it will also indicate PROGRESS to the calling party if a
tone is defined, otherwise it will still indicate RINGING. 
====================================================================== 

---------------------------------------------------------------------- 
 (0104149) tilghman (administrator) - 2009-05-04 15:26
 http://bugs.digium.com/view.php?id=14504#c104149 
---------------------------------------------------------------------- 
Since we are running out of Dial command options, I'd prefer that instead
of using the 'R' option, especially these are so close in functionality,
that you instead make the argument to the 'r' option take an optional
second parameter, such as:

Dial(...,30,r(ring,e))

such that the optional second parameter 'e' to the 'r' option specifies
whether to interrupt the indication with early media or not.  Also, it
would be helpful to note that 'ring' is the default for the first
parameter. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-05-04 15:26 tilghman       Note Added: 0104149                          
======================================================================