[asterisk-bugs] [Asterisk 0014775]: [patch] Added ability to perform SRV lookups for AGI URIs

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14775 
====================================================================== 
Reported By:                _brent_
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   14775
Category:                   Resources/res_agi/NewFeature
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     new
Asterisk Version:           1.6.1.0-rc3 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-03-27 13:24 CDT
Last Modified:              2009-03-27 14:24 CDT
====================================================================== 
Summary:                    [patch] Added ability to perform SRV lookups for AGI
URIs
Description: 
With this patch, you can run the Agi() dial plan application with a URI
beginning with hagi:// (for HA Agi) to indicate that the host name should
be resolved as an SRV service instead of a regular host name.
====================================================================== 

---------------------------------------------------------------------- 
 (0102310) eliel (manager) - 2009-03-27 14:24
 http://bugs.digium.com/view.php?id=14775#c102310 
---------------------------------------------------------------------- 
Please read the coding guidelines
(http://svn.digium.com/svn/asterisk/trunk/doc/CODING-GUIDELINES).

I didn't test the functionality just did a simple code review:
*) Always check for errors when allocating memory (ast_strdupa)
*) Use braces on ifs and whiles:
    if (a) {
    }
*) Use Doxygen when documenting functions and remember if it is a static
function to put the \internal tag (launch_ha_netscript).
*) You need to use AST_LIST_TRAVERSE_SAFE_BEGIN if you are going to remove
an element from the list when traversing it, i don't think this is the case
(or i am missing something).
*) Instead of a big 
  if (!connection_mode) {

  }
  try to avoid indentation using something like:
  if (connection_mode) {
        continue;
  } 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-03-27 14:24 eliel          Note Added: 0102310                          
======================================================================