[asterisk-bugs] [DAHDI-linux 0013897]: [patch] Support for generic HFC-4S cards

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13897 
====================================================================== 
Reported By:                tzafrir
Assigned To:                tzafrir
====================================================================== 
Project:                    DAHDI-linux
Issue ID:                   13897
Category:                   wcb4xxp
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     confirmed
====================================================================== 
Date Submitted:             2008-11-13 16:17 CST
Last Modified:              2009-03-17 11:01 CDT
====================================================================== 
Summary:                    [patch] Support for generic HFC-4S cards
Description: 
A patch to add some basic support of other HFC-4S -based PCI cards (such as
the ones made by Junghanns). 

Status: gets rid of the echo canceller messages when not needed, but still
needs work.

Specifically:
* It adds too broad a range of cards (which also include bero.net cards) 
* The range may include some 2-ports cards, which will probably not work.

Not yet tested to work, though it it is at least configured.

====================================================================== 

---------------------------------------------------------------------- 
 (0101875) Odicha (reporter) - 2009-03-17 11:01
 http://bugs.digium.com/view.php?id=13897#c101875 
---------------------------------------------------------------------- 
Only one thing

+static void b4xxp_update_leds_hfc_8s(struct b4xxp *b4)
..................................
+	b4->blinktimer++;
+	for (j = 7; j >= 0; j--) {
+		bspan = &b4->spans[7 - j];
+		if ((bspan->span.flags & DAHDI_FLAG_RUNNING) || 
+				bspan->span.alarms) {
+			BIT_SET(lled, j);
+			continue;  /* Led OFF */

Change 

+		if ((!(bspan->span.flags & DAHDI_FLAG_RUNNING))|| 
+				bspan->span.alarms) {
+			BIT_SET(lled, j);
+			continue;  /* Led OFF */

 (If is not running or there are alarms)

In first case always is true (It's running) and lights don't turn on
because always continues.

Tested ok with this change in OpenVox B800P & B200P TE & NT modes.
Only this change and I think it can go into SVN.
Congratulations Tzafrir! 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-03-17 11:01 Odicha         Note Added: 0101875                          
======================================================================