[asterisk-bugs] [Asterisk 0014068]: [patch] COLP/CONP support in QSIG

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14068 
====================================================================== 
Reported By:                nreinartz
Assigned To:                rmudgett
====================================================================== 
Project:                    Asterisk
Issue ID:                   14068
Category:                   Channels/chan_dahdi/NewFeature
Reproducibility:            N/A
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2008-12-12 07:42 CST
Last Modified:              2009-03-17 06:54 CDT
====================================================================== 
Summary:                    [patch] COLP/CONP support in QSIG
Description: 
There's work in progress at Digium to implement COLP/CONP in asterisk team
branch issue8824 http://svn.digium.com/view/asterisk/team/group/issue8824.
Connected line and number presentation now is also supported in ISDN/QSIG
by two patchfiles attached to this issue.

The number and line presentation not only works for simple calls (for
called and calling party number) but also for call diversion and call
transfer.
This means divertingLegInformation1, divertingLegInformation2,
divertingLegInformation3, callTransferComplete, callTransferActive,
CalledName, ... are supported in QSIG.
It has been tested with HiPath 3000 V4.0 and HICOM 300.

libpri-1.4-2008-12-10-colpconp-0.1.0.patch adds COLP/CONP support to
libpri-1.4 branch. This patch includes lots of new functions for QSIG apdu
encoding and decoding and also fixes some bugs related to QSIG
encoding/encoding.

asterisk-issue8824-2008-12-10-colpconp-0.1.0.patch is used to patch
chan_dahdi.c in asterisk-issue8824.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0008824 [patch] Remote (called) Party Identific...
related to          0014292 [patch] CCBS/CCNR support for QSIG (lib...
has duplicate       0012357 [patch] add called/connected/busy name ...
====================================================================== 

---------------------------------------------------------------------- 
 (0101858) fabled (reporter) - 2009-03-17 06:54
 http://bugs.digium.com/view.php?id=14068#c101858 
---------------------------------------------------------------------- 
Tested some basic cases and they seem to work. I did notice that under some
compiler settings I get an error at
rose_presented_number_unscreened_encode(), case PRES_UNAVAILABLE:
ASN1_FIXUP() line that array is accessed out of bounds.

I think the ASN1_FIXUP() is not correct there, since ASN1_PUSH() is not
called earlier. The ASN1_FIXUP() call should be just deleted there, right? 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-03-17 06:54 fabled         Note Added: 0101858                          
======================================================================