[asterisk-bugs] [LibSS7 0014677]: ss7_add_link, handling of parameter `name'

[Asterisk Bug Tracker]

The following issue has been SUBMITTED. 
====================================================================== 
http://bugs.digium.com/view.php?id=14677 
====================================================================== 
Reported By:                Safari
Assigned To:                mattf
====================================================================== 
Project:                    LibSS7
Issue ID:                   14677
Category:                   General
Reproducibility:            N/A
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2009-03-16 11:51 CDT
Last Modified:              2009-03-16 11:51 CDT
====================================================================== 
Summary:                    ss7_add_link, handling of parameter `name'
Description: 
in ss7.c:ss7_add_link(),

  if (!name && (name[0] == 0))
    return -1;

is obviously wrong.
it checks for '\0' first char in name only if you pass the function a
zero, in which case it segfaults for me.

Did you mean || instead of && ?

ss7linktest.c:main() calls ss7_add_link with parameter 3 as `fd', do you
have comments about that?

====================================================================== 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-03-16 11:51 Safari         New Issue                                    
2009-03-16 11:51 Safari         Status                   new => assigned     
2009-03-16 11:51 Safari         Assigned To               => mattf           
2009-03-16 11:51 Safari         Asterisk Version          => SVN             
2009-03-16 11:51 Safari         SVN Branch (only for SVN checkouts, not tarball
releases) => N/A             
======================================================================