[asterisk-bugs] [Asterisk 0014227]: queue-thankyou should be played only if needed

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14227 
====================================================================== 
Reported By:                caspy
Assigned To:                mmichelson
====================================================================== 
Project:                    Asterisk
Issue ID:                   14227
Category:                   Applications/app_queue
Reproducibility:            always
Severity:                   feature
Priority:                   normal
Status:                     closed
Target Version:             1.6.2.0
Asterisk Version:           1.6.0.3-rc1 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-01-13 07:27 CST
Last Modified:              2009-03-13 16:27 CDT
====================================================================== 
Summary:                    queue-thankyou should be played only if needed
Description: 
In say_position() in app_queue.c there is a command to play
'queue-thankyou' sound:
  res = play_file(qe->chan, qe->parent->sound_thanks);

This sound is played unconditionally, but should be played only in case if
position or holdtime was played.
Current code is generating 'queue-thankyou' without anything else, for
example, in case of position turned off + holdtime turned on, and hold time
less than a 1 minute.
====================================================================== 

---------------------------------------------------------------------- 
 (0101763) svnbot (reporter) - 2009-03-13 16:27
 http://bugs.digium.com/view.php?id=14227#c101763 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 182123

_U  branches/1.6.1/
U   branches/1.6.1/apps/app_queue.c

------------------------------------------------------------------------
r182123 | mmichelson | 2009-03-13 16:27:08 -0500 (Fri, 13 Mar 2009) | 12
lines

Merged revisions 182121 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

........
  r182121 | mmichelson | 2009-03-13 16:26:20 -0500 (Fri, 13 Mar 2009) | 6
lines
  
  Change faulty comparison used when announcing average hold minutes and
seconds
  
  (closes issue http://bugs.digium.com/view.php?id=14227)
  Reported by: caspy
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=182123 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-03-13 16:27 svnbot         Checkin                                      
2009-03-13 16:27 svnbot         Note Added: 0101763                          
======================================================================