[asterisk-bugs] [Asterisk 0014227]: queue-thankyou should be played only if needed

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14227 
====================================================================== 
Reported By:                caspy
Assigned To:                mmichelson
====================================================================== 
Project:                    Asterisk
Issue ID:                   14227
Category:                   Applications/app_queue
Reproducibility:            always
Severity:                   feature
Priority:                   normal
Status:                     assigned
Target Version:             1.6.2.0
Asterisk Version:           1.6.0.3-rc1 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-01-13 07:27 CST
Last Modified:              2009-03-13 07:04 CDT
====================================================================== 
Summary:                    queue-thankyou should be played only if needed
Description: 
In say_position() in app_queue.c there is a command to play
'queue-thankyou' sound:
  res = play_file(qe->chan, qe->parent->sound_thanks);

This sound is played unconditionally, but should be played only in case if
position or holdtime was played.
Current code is generating 'queue-thankyou' without anything else, for
example, in case of position turned off + holdtime turned on, and hold time
less than a 1 minute.
====================================================================== 

---------------------------------------------------------------------- 
 (0101715) caspy (reporter) - 2009-03-13 07:04
 http://bugs.digium.com/view.php?id=14227#c101715 
---------------------------------------------------------------------- 
mentioned line 1911 - is my mistype. correct:

1899     if ((avgholdmins+avgholdsecs) > 0 && qe->parent->announceholdtime
&&
...
1906 		if (avgholdmins > 1) {
...
1921 		if (avgholdsecs > 1) {
 
in line 1899 - comparation ok (>0), but in 1906 and 1921 lines - wrong
(>1). 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-03-13 07:04 caspy          Note Added: 0101715                          
======================================================================