[asterisk-bugs] [DAHDI-linux 0013897]: [patch] Support for generic HFC-4S cards

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13897 
====================================================================== 
Reported By:                tzafrir
Assigned To:                tzafrir
====================================================================== 
Project:                    DAHDI-linux
Issue ID:                   13897
Category:                   wcb4xxp
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     confirmed
====================================================================== 
Date Submitted:             2008-11-13 16:17 CST
Last Modified:              2009-03-13 05:08 CDT
====================================================================== 
Summary:                    [patch] Support for generic HFC-4S cards
Description: 
A patch to add some basic support of other HFC-4S -based PCI cards (such as
the ones made by Junghanns). 

Status: gets rid of the echo canceller messages when not needed, but still
needs work.

Specifically:
* It adds too broad a range of cards (which also include bero.net cards) 
* The range may include some 2-ports cards, which will probably not work.

Not yet tested to work, though it it is at least configured.

====================================================================== 

---------------------------------------------------------------------- 
 (0101710) tzafrir (manager) - 2009-03-13 05:08
 http://bugs.digium.com/view.php?id=13897#c101710 
---------------------------------------------------------------------- 
I'm refactoring the patch a bit.

A few points to consider:

1. Please try to provide a patch that can be applied with patch -p0 . You
can use 'svn diff' . The patch you provided uses full path and thus
required removing a random number of path elements (4, in this case, thus
patch -p4).

2. Now that we have span_type there's no more point in has_ec . I replaced
it with:

  #define CARD_HAS_EC(card) ((card)->card_type == B410P)

The name is descriptive enough to remove the need for extra comments in
those lines.

3. I'm refactoring the leds handling functions to use the BIT macros. I
suddenly ran into:

  lled |= 0 << j;

Is that supposed to be a '&=' ? lled does not seem to be initialized
anywhere.

Looks like it will take me a bit longer than expected to get this one into
shape. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-03-13 05:08 tzafrir        Note Added: 0101710                          
======================================================================