[asterisk-bugs] [Asterisk 0014647]: Incorrect argument parsing in RetryDial causes asterisk to crash

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14647 
====================================================================== 
Reported By:                sherpya
Assigned To:                file
====================================================================== 
Project:                    Asterisk
Issue ID:                   14647
Category:                   Applications/app_dial
Reproducibility:            always
Severity:                   crash
Priority:                   normal
Status:                     closed
Asterisk Version:           1.6.0.6 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-03-11 19:17 CDT
Last Modified:              2009-03-12 08:28 CDT
====================================================================== 
Summary:                    Incorrect argument parsing in RetryDial causes
asterisk to crash
Description: 
RetryDial(fpm-world-mix|5|3|LOCAL/sherpya)

yes syntax is wrong

function retrydial_exec

line 1993
sleep = atoi(args.sleep)

line 1996
loops = atoi(args.retries)

same in svn
they are two null pointers passed to atoi

a check on args.sleep and args.retries is enough :)


====================================================================== 

---------------------------------------------------------------------- 
 (0101637) svnbot (reporter) - 2009-03-12 08:28
 http://bugs.digium.com/view.php?id=14647#c101637 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 181614

_U  branches/1.6.1/
U   branches/1.6.1/apps/app_dial.c

------------------------------------------------------------------------
r181614 | file | 2009-03-12 08:28:39 -0500 (Thu, 12 Mar 2009) | 12 lines

Merged revisions 181612 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

........
  r181612 | file | 2009-03-12 10:24:12 -0300 (Thu, 12 Mar 2009) | 5 lines
  
  Fix crash when sleep and retries argument was not given to RetryDial
application.
  
  (closes issue http://bugs.digium.com/view.php?id=14647)
  Reported by: sherpya
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=181614 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-03-12 08:28 svnbot         Checkin                                      
2009-03-12 08:28 svnbot         Note Added: 0101637                          
======================================================================