[asterisk-bugs] [Asterisk 0013713]: [patch] Inband DTMF on outbound call is not detected when dtmfmode=auto

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13713 
====================================================================== 
Reported By:                makoto
Assigned To:                file
====================================================================== 
Project:                    Asterisk
Issue ID:                   13713
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           1.2.X 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2008-10-16 03:22 CDT
Last Modified:              2009-03-11 11:42 CDT
====================================================================== 
Summary:                    [patch] Inband DTMF on outbound call is not detected
when dtmfmode=auto
Description: 
Inband DTMF on outbound call is not detected when dtmfmode=auto
because p->vad (DSP for detecting inband DTMF) is not created.
On outbound call, p->vad is not created in sip_new(), so should be
created
in process_sdp() when dtmfmode is switched to inband.

I have tested only on 1.2, but I believe that it happens on 1.4 or later.

Attached patch will fix the problem.

====================================================================== 

---------------------------------------------------------------------- 
 (0101554) svnbot (reporter) - 2009-03-11 11:42
 http://bugs.digium.com/view.php?id=13713#c101554 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 181297

_U  branches/1.6.0/
U   branches/1.6.0/channels/chan_sip.c

------------------------------------------------------------------------
r181297 | file | 2009-03-11 11:42:21 -0500 (Wed, 11 Mar 2009) | 23 lines

Merged revisions 181296 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

................
  r181296 | file | 2009-03-11 13:40:48 -0300 (Wed, 11 Mar 2009) | 16 lines
  
  Merged revisions 181295 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r181295 | file | 2009-03-11 13:36:50 -0300 (Wed, 11 Mar 2009) | 9
lines
    
    Fix a problem with inband DTMF detection on outgoing SIP calls when
dtmfmode=auto.
    
    When dtmfmode was set to auto the inband DTMF detector was not setup
    on outgoing SIP calls. This caused inband DTMF detection to fail.
    The inband DTMF detector is now setup for both dtmfmode inband and
auto.
    
    (closes issue http://bugs.digium.com/view.php?id=13713)
    Reported by: makoto
  ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=181297 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-03-11 11:42 svnbot         Checkin                                      
2009-03-11 11:42 svnbot         Note Added: 0101554                          
======================================================================