[asterisk-bugs] [Asterisk 0014505]: Resolve remaining issues left over from 'kill-the-user'

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14505 
====================================================================== 
Reported By:                lmadsen
Assigned To:                russell
====================================================================== 
Project:                    Asterisk
Issue ID:                   14505
Category:                   Channels/chan_sip/General
Reproducibility:            N/A
Severity:                   block
Priority:                   high
Status:                     assigned
Target Version:             1.6.1
Asterisk Version:           1.6.1-rc1 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-02-19 08:42 CST
Last Modified:              2009-03-04 15:01 CST
====================================================================== 
Summary:                    Resolve remaining issues left over from
'kill-the-user'
Description: 
(From Russell Bryant to the asterisk-dev mailing list)

Greetings,

It's getting to the point that Asterisk 1.6.1 is nearing release.  I'd 
like to cover what we have left to address before Asterisk 1.6.1 can be 
released.

First, the following page shows what mantis issues are marked as 
blocking the release of 1.6.1.  Currently, merging some updates to the 
timing API is the only thing on this list.

http://bugs.digium.com/roadmap_page.php

The other big thing on my list is to ensure that we are happy with the 
state of the chan_sip user/peer/friend situation.  Oej's kill-the-user 
patch went in for this release.  Some issues came up, and a number of 
issues have already been fixed.  We need to determine if there is 
anything left to do in this area before 1.6.1.

Oej has written a document that describes how user/peer/friend matching 
should work here:

http://svn.digium.com/view/asterisk/team/oej/sip-compliance/sipobjects.txt?view=markup

I think that what is written here sounds good to me.  Does anyone else 
have any comments?  Also, do we have code to write to get this to be the 
reality in the 1.6.1 code base?

====================================================================== 

---------------------------------------------------------------------- 
 (0101224) svnbot (reporter) - 2009-03-04 15:01
 http://bugs.digium.com/view.php?id=14505#c101224 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 180261

U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r180261 | russell | 2009-03-04 15:01:05 -0600 (Wed, 04 Mar 2009) | 54
lines

Resolve object matching issues related to the removal of the sip_user
object.

Previously, chan_sip had both sip_peer and sip_user objects in memory.  A
patch went in to remove sip_user to simplify the code, since everything
could be done with just sip_peer.  This patch resolves some regressions
found that were introduced by those changes.

This code comes from svn/asterisk/team/group/sip-object-matching/.

Here is a list of the changes that have been made:

1) When doing a match by name with the find_peer() function, make it much
   easier to specify which objects should be matched by having a parameter
   that specifies exactly which object types should be considered.  Also,
   update find_by_name() to handle this parameter.  Finally, update all
   code to use the new option values.

2) When looking up an object for an outbound request by name, consider
   peers only.  (create_addr())

3) Only match peers on an incoming registration request.

4) When doing authentication (except for SUBSCRIBE), look up users
   by name, instead of all objects by name.
   
5) When doing authentication (except for SUBSCRIBE), after looking for
   a user by name, look for a peer by IP address, instead of all objects
   by IP address.

6) When handling the SIP qualify CLI command or manager action, look for
   a peer by name, instead of any object by name.

7) When handling the SIP unregister CLI command, look for a peer by name,
   instead of any object by name.

9) In sip_do_debug_peer(), search for a peer by name, instead of any
object
   by name.

9) When handling the SIPPEER() dialplan function, search for a peer by
name,
   instead of any object by name.

10) In the following session timer related functions, st_get_se(),
    st_get_refresher(), and st_get_mode(), when looking for an object for
a
    given sip_pvt using pvt->peername, look for a peer by name, instead of
any
    object by name.

11) Fix build_peer() to properly handle the case where separate type=peer
and
    type=user entries were specified in sip.conf.

(closes issue http://bugs.digium.com/view.php?id=14505)
Reported by: lmadsen

Review: http://reviewboard.digium.com/r/172/

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=180261 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-03-04 15:01 svnbot         Checkin                                      
2009-03-04 15:01 svnbot         Note Added: 0101224                          
======================================================================