[asterisk-bugs] [Asterisk 0014279]: [patch] Pressing only # when app_read is playing multiple prompts does not act as expected

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14279 
====================================================================== 
Reported By:                Marquis
Assigned To:                dvossel
====================================================================== 
Project:                    Asterisk
Issue ID:                   14279
Category:                   Applications/app_read
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           SVN 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 169329 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-01-19 13:10 CST
Last Modified:              2009-03-03 17:39 CST
====================================================================== 
Summary:                    [patch] Pressing only # when app_read is playing
multiple prompts does not act as expected
Description: 
When multiple ampersand-delimited prompts are passed to app_read, pressing
# (without pressing other DTMF keys) merely cycles through the prompts
until it reaches the last one.  Then it will *finally* skip that prompt and
return to the dialplan.
====================================================================== 

---------------------------------------------------------------------- 
 (0101159) svnbot (reporter) - 2009-03-03 17:39
 http://bugs.digium.com/view.php?id=14279#c101159 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 180080

_U  branches/1.6.1/
U   branches/1.6.1/apps/app_read.c
U   branches/1.6.1/include/asterisk/app.h
U   branches/1.6.1/main/app.c
U   branches/1.6.1/main/channel.c

------------------------------------------------------------------------
r180080 | dvossel | 2009-03-03 17:39:26 -0600 (Tue, 03 Mar 2009) | 19
lines

Merged revisions 180032 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

........
  r180032 | dvossel | 2009-03-03 17:21:18 -0600 (Tue, 03 Mar 2009) | 14
lines
  
  app_read does not break from prompt loop with user terminated empty
string
  
  In app.c, ast_app_getdata is called to stream the prompts and receive
DTMF input.  If ast_app_getdata() receives an empty string caused by the
user inputing the end of string character, in this case '#', it should
break from the prompt loop and return to app_read, but instead it cycles
through all the prompts.  I've added a return value for this special case
in ast_readstring() which uses an enum I've delcared in apps.h.  This enum
is now used as a return value for ast_app_getdata().
  
  (closes issue http://bugs.digium.com/view.php?id=14279)
  Reported by: Marquis
  Patches:
  	fix_app_read.patch uploaded by Marquis (license 32)
  	read-ampersanmd.patch2 uploaded by dvossel (license 671)
  Tested by: Marquis, dvossel
  Review: http://reviewboard.digium.com/r/177/
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=180080 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-03-03 17:39 svnbot         Checkin                                      
2009-03-03 17:39 svnbot         Note Added: 0101159                          
======================================================================