[asterisk-bugs] [Asterisk 0012761]: [patch] chan_sip: build_contact() does not put alternate port setting in Contact header

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12761 
====================================================================== 
Reported By:                asbestoshead
Assigned To:                mmichelson
====================================================================== 
Project:                    Asterisk
Issue ID:                   12761
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 118255 
Request Review:              
====================================================================== 
Date Submitted:             2008-05-30 03:04 CDT
Last Modified:              2009-03-02 17:15 CST
====================================================================== 
Summary:                    [patch] chan_sip: build_contact() does not put
alternate port setting in Contact header
Description: 
build_contact() looks at the *other* end's port to decide whether there's a
non-standard port in use. If my end has bindport=5062 but the peer has
port=5060, when I send an invite to the peer, my Contact header doesn't
have ":5062".

initreqprep() has the same problem when setting the From: header.

chan_sip in Asterisk trunk and 1.6.0-beta8 (but not 1.4.19) have this
problem.

I have a trivial patch for this against Moy's mfcr2 branch off trunk, but
I can't find the link to sign the contributor's agreement. The patch also
applies to 1.6.0beta8, although I haven't tested it there...
====================================================================== 

---------------------------------------------------------------------- 
 (0101046) svnbot (reporter) - 2009-03-02 17:15
 http://bugs.digium.com/view.php?id=12761#c101046 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 179473

_U  branches/1.6.0/
U   branches/1.6.0/channels/chan_sip.c

------------------------------------------------------------------------
r179473 | mmichelson | 2009-03-02 17:15:52 -0600 (Mon, 02 Mar 2009) | 17
lines

Merged revisions 151464 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

........
  r151464 | mmichelson | 2008-10-21 18:54:41 -0500 (Tue, 21 Oct 2008) | 11
lines
  
  Make the sip_standard_port function more granular by allowing separate
  type and port arguments. This is necessary because when building our
From
  and Contact headers, we need to be absolutely sure that we are placing
our
  source port there and not the peer's source port.
  
  (closes issue http://bugs.digium.com/view.php?id=12761)
  Reported by: asbestoshead
  Patches:
        patch-chan-sip-contact-port.txt uploaded by asbestoshead (license
455)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=179473 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-03-02 17:15 svnbot         Checkin                                      
2009-03-02 17:15 svnbot         Note Added: 0101046                          
======================================================================