[asterisk-bugs] [Asterisk 0014406]: [patch] Voicemail message recording file is shorter than duration reported in msg????.txt

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14406 
====================================================================== 
Reported By:                sasargen
Assigned To:                tilghman
====================================================================== 
Project:                    Asterisk
Issue ID:                   14406
Category:                   Applications/app_voicemail
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     ready for testing
Target Version:             1.4.24
Asterisk Version:           1.4.23 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-02-04 13:24 CST
Last Modified:              2009-03-02 16:37 CST
====================================================================== 
Summary:                    [patch] Voicemail message recording file is shorter
than duration reported in msg????.txt
Description: 
Voicemail says message duration is maxsilence seconds longer than the
actual voicemail recording length.

Error is occuring when maxsilence is exceeded. Silence is trimmed from the
end of the recording file, but the duration reported for the message is not
updated to match the recording saved.
====================================================================== 

---------------------------------------------------------------------- 
 (0101034) sasargen (reporter) - 2009-03-02 16:37
 http://bugs.digium.com/view.php?id=14406#c101034 
---------------------------------------------------------------------- 
Patch doesn't return correct duration. (totalsilence - 200) is in
milliseconds but duration is in seconds, so they cannot be directly
subtracted from eachother. 

It appears that the following line:
     *duration -= (totalsilence - 200);
results in a negative value that the code then sets to 0.

The following change to the patch seems to be a fix:
     *duration -= ((totalsilence - 200) / 1000); 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-03-02 16:37 sasargen       Note Added: 0101034                          
======================================================================