[asterisk-bugs] [Asterisk 0014452]: in "_sip_tcp_helper_thread" Buffer is filled with dirty bytes

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=14452 
====================================================================== 
Reported By:                umberto71
Assigned To:                russell
====================================================================== 
Project:                    Asterisk
Issue ID:                   14452
Category:                   Channels/chan_sip/TCP-TLS
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           1.6.0.1 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-02-10 10:36 CST
Last Modified:              2009-06-26 15:48 CDT
====================================================================== 
Summary:                    in "_sip_tcp_helper_thread" Buffer is filled with
dirty bytes
Description: 
I've seen with aastra phones 51i and 57i that buffer "buf" is not empty
with TLS. 
I suggest to do this patch
.....
	for (;;) {
		memset(req.data, 0, sizeof(req.data));
		memset(buf, 0, sizeof(buf));  //<<<<<<<<<<<<<<<<<<< Patch
		req.len = 0;
		req.ignore = 0;
		req.debug = 0;
.....
====================================================================== 

---------------------------------------------------------------------- 
 (0107058) svnbot (reporter) - 2009-06-26 15:48
 https://issues.asterisk.org/view.php?id=14452#c107058 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 203781

_U  branches/1.6.1/
U   branches/1.6.1/channels/chan_sip.c

------------------------------------------------------------------------
r203781 | russell | 2009-06-26 15:48:32 -0500 (Fri, 26 Jun 2009) | 12
lines

Merged revisions 203779 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

........
  r203779 | russell | 2009-06-26 15:45:00 -0500 (Fri, 26 Jun 2009) | 5
lines
  
  Ensure the TCP read buffer is fully initialized before handling each
packet.
  
  (closes issue https://issues.asterisk.org/view.php?id=14452)
  Reported by: umberto71
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=203781 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-06-26 15:48 svnbot         Checkin                                      
2009-06-26 15:48 svnbot         Note Added: 0107058                          
======================================================================