[asterisk-bugs] [Asterisk 0015331]: [patch] Log message does not match conditional check

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15331 
====================================================================== 
Reported By:                markd
Assigned To:                dbrooks
====================================================================== 
Project:                    Asterisk
Issue ID:                   15331
Category:                   Applications/app_voicemail
Reproducibility:            have not tried
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           1.4.25 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-06-15 07:48 CDT
Last Modified:              2009-06-26 15:13 CDT
====================================================================== 
Summary:                    [patch] Log message does not match conditional check
Description: 
I beleive the following lines to be incorrect.  The comparitor should be
">=" and not "<=" or the log message should be reworded.

if (maxsilence <= vmminsecs)
      ast_log(AST_LOG_WARNING, "maxsilence should be less than minmessage
or you may get empty messages\n");

====================================================================== 

---------------------------------------------------------------------- 
 (0107049) svnbot (reporter) - 2009-06-26 15:13
 https://issues.asterisk.org/view.php?id=15331#c107049 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 203721

U   trunk/apps/app_voicemail.c

------------------------------------------------------------------------
r203721 | dbrooks | 2009-06-26 15:13:52 -0500 (Fri, 26 Jun 2009) | 16
lines

Fixing voicemail's error in checking max silence vs min message length

Max silence was represented in milliseconds, yet vmminsecs (minmessage)
was represented
as seconds.

Also, the inequality was reversed. The warning, if triggered, was "Max
silence should 
be less than minmessage or you may get empty messages", which should have
been logged 
if max silence was greater than minmessage, but the check was for less
than.

Also, conforming if statement to coding guidelines.

closes issue https://issues.asterisk.org/view.php?id=15331)
Reported by: markd

Review: https://reviewboard.asterisk.org/r/293/

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=203721 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-06-26 15:13 svnbot         Checkin                                      
2009-06-26 15:13 svnbot         Note Added: 0107049                          
======================================================================