[asterisk-bugs] [Asterisk 0014674]: [patch] Dial application with the 'n' option not removing introductions

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=14674 
====================================================================== 
Reported By:                ulogic
Assigned To:                dvossel
====================================================================== 
Project:                    Asterisk
Issue ID:                   14674
Category:                   Applications/app_dial
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.6.0.7-rc1 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-03-16 10:35 CDT
Last Modified:              2009-06-26 14:18 CDT
====================================================================== 
Summary:                    [patch] Dial application with the 'n' option not
removing introductions
Description: 
When using the 'p' screening option with the 'n' non-persistent option, the
introductions are not supposed to be saved in the priv-callerintros
directory.  However, the only time they are deleted in the current code is
when the called party accepts the call by pressing the 1 key.

Caller A makes a call and dials the extension for called party P.  The
call screening asks A to say the name to present to P.  P does not answer
the call because P is on the phone, away from the desk, or sent the call to
voice mail.  Later caller B make a call from the phone number.  Because
announcement file still exists for that phone number, no prompt for the
name is given, and the announcement given to P is the response from A.  P
picks up the phone thinking that A has called and is surprised to find B on
the line.

This behavior goes back to Asterisk version 1.2.

Also the help messages for the p and P options are not real clear.


====================================================================== 

---------------------------------------------------------------------- 
 (0107033) dvossel (administrator) - 2009-06-26 14:18
 https://issues.asterisk.org/view.php?id=14674#c107033 
---------------------------------------------------------------------- 
I've reviewed the patch and have some comments, shouldn't the intro file
just be deleted at the end of the call if the 'n' option is used rather
than using fstat to get the file's creation time to tell whether it is new
or old?  Since this has been around for so long, is there any chance this
could be a behavior change people won't necessarily want? 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-06-26 14:18 dvossel        Note Added: 0107033                          
======================================================================