[asterisk-bugs] [Asterisk 0015370]: [patch] Repeatedly building the asterisk directory repeatedly downloads the sounds files

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15370 
====================================================================== 
Reported By:                pprindeville
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   15370
Category:                   Core/BuildSystem
Reproducibility:            always
Severity:                   tweak
Priority:                   normal
Status:                     new
Asterisk Version:           1.4.25.1 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-06-22 00:18 CDT
Last Modified:              2009-06-22 00:25 CDT
====================================================================== 
Summary:                    [patch] Repeatedly building the asterisk directory
repeatedly downloads the sounds files
Description: 
If you have a source tree, and repeatedly do "make ; make dist-clean" ...
(lather, rinse, repeat) for multiple platforms, then you end up fetching
the sounds files over and over again.

This fix allows one to cache the files outside of the source tree by
setting the variable "SOUNDS_CACHE_DIR" to some path outside the tree.

Subsequent builds will copy the file from there when rebuilding.

====================================================================== 

---------------------------------------------------------------------- 
 (0106765) pprindeville (reporter) - 2009-06-22 00:25
 https://issues.asterisk.org/view.php?id=15370#c106765 
---------------------------------------------------------------------- 
Tested locally with and without caching enabled.

I've not tried this for languages other than English.

The sequence:

       if test ! -f $${PACKAGE}; then $(DOWNLOAD) $(WGET_ARGS)
$(SOUNDS_URL)/$${PACKAGE}; fi; \
       if test ! -f $${PACKAGE}; then exit 1; fi; \

Was shortened to:

       if test ! -f $${PACKAGE}; then \
         ($(DOWNLOAD) $(WGET_ARGS) $(SOUNDS_URL)/$${PACKAGE} || exit 1);
\
       fi; \

Hopefully "wget" fails with the appropriate status code in all cases. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-06-22 00:25 pprindeville   Note Added: 0106765                          
======================================================================