[asterisk-bugs] [Asterisk 0015361]: [patch] AST-2009-001 breaks IAX2 RFC5456 compliance - Timestamps in POKE/PONG zero in 2 of 4 Bytes

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15361 
====================================================================== 
Reported By:                ffloimair
Assigned To:                dvossel
====================================================================== 
Project:                    Asterisk
Issue ID:                   15361
Category:                   Channels/chan_iax2
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     closed
Asterisk Version:           1.4.25.1 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-06-19 04:19 CDT
Last Modified:              2009-06-19 15:27 CDT
====================================================================== 
Summary:                    [patch] AST-2009-001 breaks IAX2 RFC5456 compliance
- Timestamps in POKE/PONG zero in 2 of 4 Bytes
Description: 
When using POKE/PONG requests the timestamp values are broken. Since 1.4.25
the timestamp in POKE and PONG IEs were identical.
However, when using Asterisk 1.4.25.1 in the POKE IE on PowerPC platforms
the first 2 Bytes of the 4 Byte Timestamp are always 0, the second 2 Bytes
are identical to the value in the PONG IE, so obviously the first two Bytes
are zeroed for some reason. On x86 platforms however, the first two bytes
are also zero and the second two Bytes show the value that is supposed to
be in the first two Bytes.

Seems like there is 2 problems at once (endianess & addressing). 
====================================================================== 

---------------------------------------------------------------------- 
 (0106737) svnbot (reporter) - 2009-06-19 15:27
 https://issues.asterisk.org/view.php?id=15361#c106737 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 201997

_U  branches/1.6.0/
U   branches/1.6.0/channels/chan_iax2.c

------------------------------------------------------------------------
r201997 | dvossel | 2009-06-19 15:27:31 -0500 (Fri, 19 Jun 2009) | 21
lines

Merged revisions 201994 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

................
  r201994 | dvossel | 2009-06-19 15:24:37 -0500 (Fri, 19 Jun 2009) | 14
lines
  
  Merged revisions 201993 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r201993 | dvossel | 2009-06-19 15:22:02 -0500 (Fri, 19 Jun 2009) | 8
lines
    
    timestamp was being converted to host order as a short rather than a
long
    
    (closes issue https://issues.asterisk.org/view.php?id=15361)
    Reported by: ffloimair
    Patches:
          ts_issue.diff uploaded by dvossel (license 671)
  ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=201997 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-06-19 15:27 svnbot         Checkin                                      
2009-06-19 15:27 svnbot         Note Added: 0106737                          
======================================================================