[asterisk-bugs] [Asterisk 0015331]: [patch] Log message does not match conditional check

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15331 
====================================================================== 
Reported By:                markd
Assigned To:                dbrooks
====================================================================== 
Project:                    Asterisk
Issue ID:                   15331
Category:                   Applications/app_voicemail
Reproducibility:            have not tried
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.4.25 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-06-15 07:48 CDT
Last Modified:              2009-06-18 11:28 CDT
====================================================================== 
Summary:                    [patch] Log message does not match conditional check
Description: 
I beleive the following lines to be incorrect.  The comparitor should be
">=" and not "<=" or the log message should be reworded.

if (maxsilence <= vmminsecs)
      ast_log(AST_LOG_WARNING, "maxsilence should be less than minmessage
or you may get empty messages\n");

====================================================================== 

---------------------------------------------------------------------- 
 (0106656) dbrooks (manager) - 2009-06-18 11:28
 https://issues.asterisk.org/view.php?id=15331#c106656 
---------------------------------------------------------------------- 
I think you were right, markd, The inequality was backwards. But in
addition to that, maxsilence's value was in milliseconds, so it would
always be greater than minmessage (unless your minmessage was in the
thousands of seconds). These two patches (for 1.4 and trunk) should fix
that. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-06-18 11:28 dbrooks        Note Added: 0106656                          
======================================================================