[asterisk-bugs] [Asterisk 0015111]: [patch] parsing of sip register lines is broken

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15111 
====================================================================== 
Reported By:                ffs
Assigned To:                dvossel
====================================================================== 
Project:                    Asterisk
Issue ID:                   15111
Category:                   Channels/chan_sip/Registration
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     closed
Target Version:             1.6.2.0
Asterisk Version:           1.6.2.0-beta1 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-05-14 11:03 CDT
Last Modified:              2009-06-18 10:24 CDT
====================================================================== 
Summary:                    [patch] parsing of sip register lines is broken
Description: 
A register line within sip.conf has the following format:

[transport://]user[:secret[:authuser]]@domain[:port][/extension][~expiry]

To extract the extension the parser is searching for '/' in the whole line
(from right to left).
As [/extension] is optional this causes trouble if there is no extension
defined and [transport://] is set.

Suggested solution: parse extension and expiry after the last '@'
character.

A backport to affected older versions would be appreciated.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0014668 register: '/' in username not supported
has duplicate       0015342 parsing of sip register lines is still ...
====================================================================== 

---------------------------------------------------------------------- 
 (0106636) svnbot (reporter) - 2009-06-18 10:24
 https://issues.asterisk.org/view.php?id=15111#c106636 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 201601

_U  branches/1.6.1/
U   branches/1.6.1/channels/chan_sip.c

------------------------------------------------------------------------
r201601 | dvossel | 2009-06-18 10:24:41 -0500 (Thu, 18 Jun 2009) | 17
lines

Merged revisions 201570 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

........
  r201570 | dvossel | 2009-06-18 10:16:05 -0500 (Thu, 18 Jun 2009) | 11
lines
  
  parsing extension correctly from sip register lines
  
  If a transport type was specified, but no extension, parsing of the
extension would return whatever was after the transport rather than
defaulting to 's'.
  
  (closes issue https://issues.asterisk.org/view.php?id=15111)
  Reported by: ffs
  Patches:
        chan_sip.c_register-parser.patch uploaded by ffs (license 730)
  Tested by: ffs, dvossel
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=201601 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-06-18 10:24 svnbot         Checkin                                      
2009-06-18 10:24 svnbot         Note Added: 0106636                          
======================================================================