[asterisk-bugs] [Zaptel 0014382]: ztdummy module compliation error on PPC

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=14382 
====================================================================== 
Reported By:                dosnibbles
Assigned To:                
====================================================================== 
Project:                    Zaptel
Issue ID:                   14382
Category:                   ztdummy
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     feedback
Zaptel Version:              SVN 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!): 4542 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2009-02-01 22:42 CST
Last Modified:              2009-06-18 09:45 CDT
====================================================================== 
Summary:                    ztdummy module compliation error on PPC
Description: 
When compiling the latest version of zaptel, the compiler errors on ztdummy
module. All other modules compiled.

Source was checked out of SVN repository:

Revision: 4542 $, $Date: 2008-09-23 23:27:41 -0700 (Tue, 23 Sep 2008)

Linux 2.6.27-1.ydl61.4 https://issues.asterisk.org/view.php?id=1 SMP Wed Nov 19
02:04:32 EST 2008 ppc GNU/Linux
Yellow Dog Linux release 6.1 (Pyxis)
gcc version 4.1.2 20071124 (Red Hat 4.1.2-42)
PPC G4 450Mhz
2GB Ram
====================================================================== 

---------------------------------------------------------------------- 
 (0106629) tzafrir (manager) - 2009-06-18 09:45
 https://issues.asterisk.org/view.php?id=14382#c106629 
---------------------------------------------------------------------- 
As suggested by stevedavies: the following hunc in Zaptel r4617 (and
DAHDI-linux r5211) seems fishy:

@@ -222,7 +234,7 @@ static enum hrtimer_restart ztdummy_hr_int(struct
hrtimer *h
 /* use kernel system tick timer if PC architecture RTC is not available
*/
 static void ztdummy_timer(unsigned long param)
 {
-       timer.expires = jiffies + 1;
+       hrtimer_set_expires(timer, jiffies + 1);
        add_timer(&timer);

        ztd->counter += ZAPTEL_TIME;


It should probably be reverted. The DAHDI one seems to have already been
removed as part of the dahdi_dummy changes. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-06-18 09:45 tzafrir        Note Added: 0106629                          
======================================================================