[asterisk-bugs] [Asterisk 0013865]: [patch] SIP/TLS enabled - just one call possible - 481 Call/Transaction Does Not Exist

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=13865 
====================================================================== 
Reported By:                st
Assigned To:                dvossel
====================================================================== 
Project:                    Asterisk
Issue ID:                   13865
Category:                   Channels/chan_sip/TCP-TLS
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.6.1-beta1 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2008-11-09 10:03 CST
Last Modified:              2009-06-16 11:03 CDT
====================================================================== 
Summary:                    [patch] SIP/TLS enabled - just one call possible -
481 Call/Transaction Does Not Exist
Description: 
Settup consits of Asterisk 1.6.1-beta1 and Snom320 firmware 7.3.7
TLS is enabled using standard port 5061 for the first example and port
5062 for the second example.

Dialplan is very simple: Answer; Wait(1); Playback(...); Hangup;

The first call of the first example does work but it is not possible to
call the same number again: 481 Call/Transaction Does Not Exist

The first call of the second example has no "BYE" and has to be cancelled
at the phone.


(IMHO a new category chan_sip/TLS should be created)
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
has duplicate       0015009 Asterisk's not handling BYE sip-tls mes...
====================================================================== 

---------------------------------------------------------------------- 
 (0106470) svnbot (reporter) - 2009-06-16 11:03
 https://issues.asterisk.org/view.php?id=13865#c106470 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 200946

U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r200946 | dvossel | 2009-06-16 11:03:31 -0500 (Tue, 16 Jun 2009) | 32
lines

SIP transport type issues

What this patch addresses:
1. ast_sip_ouraddrfor() by default binds to the UDP address/port
reguardless if the sip->pvt is of type UDP or not.  Now when no
remapping is required, ast_sip_ouraddrfor() checks the sip_pvt's
transport type, attempting to set the address and port to the
correct TCP/TLS bindings if necessary.
2.  It is not necessary to send the port number in the Contact
header unless the port is non-standard for the transport type.
This patch fixes this and removes the todo note.
3.  In sip_alloc(), the default dialog built always uses transport
type UDP.  Now sip_alloc() looks at the sip_request (if present)
and determines what transport type to use by default.
4.  When changing the transport type of a sip_socket, the file
descriptor must be set to -1 and in some cases the tcptls_session's
ref count must be decremented and set to NULL.  I've encountered
several issues associated with this process and have created a function,
set_socket_transport(), to handle the setting of the socket type.


(closes issue https://issues.asterisk.org/view.php?id=13865)
Reported by: st
Patches:
      dont_add_port_if_tls.patch uploaded by Kristijan (license 753)
      13865.patch uploaded by mmichelson (license 60)
      tls_port_v5.patch uploaded by vrban (license 756)
      transport_issues.diff uploaded by dvossel (license 671)
Tested by: mmichelson, Kristijan, vrban, jmacz, dvossel

Review: https://reviewboard.asterisk.org/r/278/

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=200946 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-06-16 11:03 svnbot         Checkin                                      
2009-06-16 11:03 svnbot         Note Added: 0106470                          
======================================================================