[asterisk-bugs] [DAHDI-linux 0010244]: Allow modification of ZT_CHUNKSIZE

Asterisk Bug Tracker noreply at bugs.digium.com
Mon Jun 15 16:25:54 CDT 2009


The following issue has been CLOSED 
====================================================================== 
https://issues.asterisk.org/view.php?id=10244 
====================================================================== 
Reported By:                UVSoft
Assigned To:                
====================================================================== 
Project:                    DAHDI-linux
Issue ID:                   10244
Category:                   NewFeature
Reproducibility:            always
Severity:                   feature
Priority:                   normal
Status:                     closed
Resolution:                 suspended
Fixed in Version:           
====================================================================== 
Date Submitted:             2007-07-20 02:37 CDT
Last Modified:              2009-06-15 16:25 CDT
====================================================================== 
Summary:                    Allow modification of ZT_CHUNKSIZE
Description: 
I've made a patch that makes ZT_CHUNKSIZE variable, thus someone can change
it to whatever he wants. It's very useful, e.g. I'm working on a driver for
some device and the device requires ZT_CHUNKSIZE to be much more, it's hard
for the device to operate with chunks of 8 samples, but 80 will do. The
problem is that there are some pieces of the code, where ZT_CHUNKSIZE is
implied to be 8, and if I just change ZT_CHUNKSIZE to 80, all the timeouts
will become crazy, the patch tries to fix this issue.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0010880 Make ZT_CHUNKSIZE variable (Again?)
====================================================================== 

---------------------------------------------------------------------- 
 (0106428) sruffell (administrator) - 2009-06-15 16:25
 https://issues.asterisk.org/view.php?id=10244#c106428 
---------------------------------------------------------------------- 
This issue has lingered and I'm going to suspend it for the time being. 
While I see how this could be beneficial for hardware that cannot deal with
1ms samples.  However I still think it would be *possible* for a device
driver to split a chunk of audio into the 1ms samples when calling
dahdi_receive and dahdi_transmit. This, IMHO, would be simpler than
updating all the other card drivers to work with a DAHDI_CHUNKSIZE that is
not 8 or fail appropriately.

I do realize that there are potential performance improvements to be had
from increasing the chunk size used to process audio (less function call
overhead, better cache locality, etc..).  But if this patch is going to be
merged for performance, there needs to be some work to make it easy to
profile DAHDI and get objective numbers before.

But this issue can be reopened if someone wants to make it against the
trunk of DAHDI and there are appropriate error messages generated for all
the boards that are not updated, and selectable by flipping a flag in
include/dahdi/dahdi_config.h, then this could be reopened. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-06-15 16:25 sruffell       Note Added: 0106428                          
2009-06-15 16:25 sruffell       Status                   feedback => closed  
2009-06-15 16:25 sruffell       Resolution               open => suspended   
======================================================================




More information about the asterisk-bugs mailing list