[asterisk-bugs] [Asterisk 0015262]: [patch] RFC3261 Via-header branches not done right (section

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15262 
====================================================================== 
Reported By:                maniax
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   15262
Category:                   Channels/chan_sip/General
Reproducibility:            sometimes
Severity:                   major
Priority:                   normal
Status:                     new
Asterisk Version:           Addons-1.6.1.0 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-06-03 09:51 CDT
Last Modified:              2009-06-15 01:32 CDT
====================================================================== 
Summary:                    [patch] RFC3261 Via-header branches not done right
(section
Description: 
We're testing asterisk and res_fax against a Zoiper Communicator and got
into a SIP issue. When there's a re-INVITE to T.38, the branch parameter is
the same as for the INVITE, which in fact is wrong, because:

RFC 3261, https://issues.asterisk.org/view.php?id=8.1.1.7 : "...the branch ID
was constructed in the fashion
described by this specification (that is, globally unique)."
https://issues.asterisk.org/view.php?id=17.2.3: "
The branch parameter in the topmost Via header field of the request
is examined.  If it is present and begins with the magic cookie
"z9hG4bK", the request was generated by a client transaction
compliant to this specification.  Therefore, the branch parameter
will be unique across all transactions sent by that client.
"

Attached is a packet capture that shows this - the re-invite is not
accepted by the softphone as it has the same branch parameter and is
treated as a retransmit.
====================================================================== 

---------------------------------------------------------------------- 
 (0106385) tweety (reporter) - 2009-06-15 01:32
 https://issues.asterisk.org/view.php?id=15262#c106385 
---------------------------------------------------------------------- 
Hi maniax,

same problem here with OpenStage phones and Patton/Inalp Media Gateways.
ReInvites get simply dropped, without any error signaling.

I'm not sure which behavior is right, because some other Devices (e.g.
Microsoft OCS Mediation Server) needs a the same branch parameter in
reinvites. With the attached patch, you can control, if a new branch will
be generated. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-06-15 01:32 tweety         Note Added: 0106385                          
======================================================================