[asterisk-bugs] [Asterisk 0015286]: RTCP (SR) message is not scheduled to send backto UAC in case 2 UACs are the same codec.

[Asterisk Bug Tracker]

The following issue has been SUBMITTED. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15286 
====================================================================== 
Reported By:                tmasolutions
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   15286
Category:                   Core/RTP
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           1.6.0.5 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-06-07 21:46 CDT
Last Modified:              2009-06-07 21:46 CDT
====================================================================== 
Summary:                    RTCP (SR) message is not scheduled to send backto
UAC in case 2 UACs are the same codec.
Description: 
Hi all,

RTCP (SR) message is not scheduled to send back to UAC in case 2 UACs are
the same codec.
I implemented a solution as below, please take a look and give your
ideas.

In bridge_p2p_rtp_write function of rtp.c: add schedule sending RTCP into
else condition.
static int bridge_p2p_rtp_write(...)
	....
	res = sendto(...)
	if (res < 0) { 
	} else if (rtp_debug_test_addr(&bridged->them)) {
		ast_verbose(...);
		// My code added begin
		rtp->txcount++;
		rtp->txoctetcount +=(res - hdrlen);
		/* Do not schedule SR if RTCP isn't run */
		if (rtp->rtcp && rtp->rtcp->them.sin_addr.s_addr &&
rtp->rtcp->schedid < 1) {
			rtp->rtcp->schedid = ast_sched_add(rtp->sched,
ast_rtcp_calc_interval(rtp), ast_rtcp_write, rtp);
		}
		// My code added end
	}
	return 0;
}
====================================================================== 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-06-07 21:46 tmasolutions   New Issue                                    
2009-06-07 21:46 tmasolutions   Asterisk Version          => 1.6.0.5         
2009-06-07 21:46 tmasolutions   Regression                => No              
2009-06-07 21:46 tmasolutions   SVN Branch (only for SVN checkouts, not tarball
releases) => N/A             
======================================================================