[asterisk-bugs] [Asterisk 0015057]: [patch] hints with 2+ devices that include ONHOLD are often set wrong

Fri Jun 5 16:25:50 CDT 2009

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15057 
====================================================================== 
Reported By:                p_lindheimer
Assigned To:                dvossel
====================================================================== 
Project:                    Asterisk
Issue ID:                   15057
Category:                   Core/PBX
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           1.4.21.1 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-05-07 21:25 CDT
Last Modified:              2009-06-05 16:25 CDT
====================================================================== 
Summary:                    [patch] hints with 2+ devices that include ONHOLD
are often set wrong
Description: 
I brought this up in the dev mailing list, the crux of the issue is:

If you have a hint with two (or more) devices or a device and a custom
devstate that includes ONHOLD, you get unexpected results. Two examples:

exten => 222,hint,SIP/222&SIP/211
exten => 333,hint,Custom:DND333&SIP/333

The following results are inconsistent as they should all return ONHOLD:

ONHOLD & IDLE = IDLE
ONHOLD & UNAVAILABLE => UNAVAILABLE
ONHOLD & UNKNOWN => IDLE
ONHOLD & INVALID => IDLE

Per Russell Bryant's response on the mailing list:

"I would agree that this is a bug.  I would expect that combination of  
states to result in an OnHold state."

====================================================================== 

---------------------------------------------------------------------- 
 (0106069) svnbot (reporter) - 2009-06-05 16:25
 https://issues.asterisk.org/view.php?id=15057#c106069 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 199299

_U  branches/1.6.2/
U   branches/1.6.2/include/asterisk/devicestate.h
U   branches/1.6.2/main/devicestate.c

------------------------------------------------------------------------
r199299 | dvossel | 2009-06-05 16:25:50 -0500 (Fri, 05 Jun 2009) | 28
lines

Merged revisions 199298 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

................
  r199298 | dvossel | 2009-06-05 16:21:22 -0500 (Fri, 05 Jun 2009) | 21
lines

  Merged revisions 199297 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4

  ........
    r199297 | dvossel | 2009-06-05 16:19:56 -0500 (Fri, 05 Jun 2009) | 14
lines

    Fixes issue with hints giving unexpected results.

    Hints with two or more devices that include ONHOLD gave unexpected
results.

    (closes issue https://issues.asterisk.org/view.php?id=15057)
    Reported by: p_lindheimer
    Patches:
          onhold_trunk.diff uploaded by dvossel (license 671)
          pbx.c.1.4.patch uploaded by p (license 558)
          devicestate.c.trunk.patch uploaded by p (license 671)
    Tested by: p_lindheimer, dvossel

    Review: https://reviewboard.asterisk.org/r/254/
  ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=199299 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-06-05 16:25 svnbot         Checkin                                      
2009-06-05 16:25 svnbot         Note Added: 0106069                          
======================================================================