[asterisk-bugs] [Asterisk 0011688]: [patch] Allow Sipura handsets (SPA942) to use Asterisk SLA via implementation of Broadsoft Sip extensions

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=11688 
====================================================================== 
Reported By:                grossi
Assigned To:                dvossel
====================================================================== 
Project:                    Asterisk
Issue ID:                   11688
Category:                   Channels/chan_sip/NewFeature
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     feedback
Asterisk Version:           1.4.16.2 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 96644 
Request Review:              
====================================================================== 
Date Submitted:             2008-01-05 10:58 CST
Last Modified:              2009-07-26 16:23 CDT
====================================================================== 
Summary:                    [patch] Allow Sipura handsets (SPA942) to use
Asterisk SLA via implementation of Broadsoft Sip extensions
Description: 
Modifications in chan_sip.c and pbx.h to accommidate rudimentary
implementation of Broadsoft SIP Access side extensions with the short term
goal of achieving SLA functionality for Sipura phones (tested on SPA942's)
. 

Currently I have full SLA compatability with SPA942's working as well as
integration with other (AASTRA 53i) SLA compatible phones on asterisk. 


====================================================================== 

---------------------------------------------------------------------- 
 (0108236) grossi (reporter) - 2009-07-26 16:23
 https://issues.asterisk.org/view.php?id=11688#c108236 
---------------------------------------------------------------------- 
Thank you for the comments. I have gone thru cleaning up stylystic issues
and white space.

with regards to:
1. In transmit_state_notify() within the extension state switch case
    case AST_EXTENSION_REQLINESEIZE:
        add_header(&req, "Event" , "Line-Seize");
        add_header(&req, "Subscription-State", "active, 14");
Why is the Event header added here rather than in the CALL_INFO subscribed
switchcase below like all the others?

in the first section we are only going to send out the Line seize event
-basically ignoring it.
in the second switch, CALL_INFO (only if it is not a Line seize event) are
we going to send out the appearance state.

with regards to:
2. This may have been caused by later changes to the code, but in
transmit_state_notify() I see that tmp->string is added in the CALL_INFO:
switch case, add_header(&req, "Call-Info", tmp->str),
 and once again after the switch case a few lines below, add_line(&req,
tmp->str). I don't really  understand why that should happen. 
 
add_header requires both the "Call-Info" and  tmp->str arguments in
addition to the request pointer. When we are out of the switch context,
add_line(&req, tmp->str) cannot appropriately add the "Call-Info" header.
so I have to do it in side the switch context.

thanks again for your sugesstions. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-07-26 16:23 grossi         Note Added: 0108236                          
======================================================================