[asterisk-bugs] [Asterisk 0014239]: [patch] 491-request pending is sent out of dialog

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=14239 
====================================================================== 
Reported By:                klaus3000
Assigned To:                mmichelson
====================================================================== 
Project:                    Asterisk
Issue ID:                   14239
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           1.4.22 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-01-14 07:33 CST
Last Modified:              2009-07-23 14:35 CDT
====================================================================== 
Summary:                    [patch] 491-request pending is sent out of dialog
Description: 
Hi!

Asterisk does not handle the following scenario correctly:

--INVITE-->
<-407------
[ACK is lost]

--INVITE w/credentials-->
<-----------491----------

The 491 is wrong as the 491 is only allowed for in-dialog requests. As the
first INVITE is not accepted there is no dialog set up. Thus, Asterisk may
retransmit the 407 to trigger retransmission of the ACK, but this must be
independet from the second INVITE which should be accepted instead of
rejecting with 491 - even if the ACK was not received.

I checked lates SVN commits in chan_sip and itlooks like the problem is
still there.

This issue is maybe related to https://issues.asterisk.org/view.php?id=13849
(although in https://issues.asterisk.org/view.php?id=13849 the second
INVITE is in-dialog).
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0013849 problem handling race condition - reINV...
====================================================================== 

---------------------------------------------------------------------- 
 (0108139) svnbot (reporter) - 2009-07-23 14:35
 https://issues.asterisk.org/view.php?id=14239#c108139 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 208389

_U  branches/1.6.0/
U   branches/1.6.0/channels/chan_sip.c

------------------------------------------------------------------------
r208389 | mmichelson | 2009-07-23 14:35:32 -0500 (Thu, 23 Jul 2009) | 31
lines

Merged revisions 208388 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

................
  r208388 | mmichelson | 2009-07-23 14:34:49 -0500 (Thu, 23 Jul 2009) | 24
lines
  
  Merged revisions 208386 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r208386 | mmichelson | 2009-07-23 14:24:21 -0500 (Thu, 23 Jul 2009) |
17 lines
    
    Fix a problem where a 491 response could be sent out of dialog.
    
    This generalizes the fix for issue 13849. The initial fix corrected
the
    problem that Asterisk would reply with a 491 if a reinvite were
received
    from an endpoint and we had not yet received an ACK from that endpoint
    for the initial INVITE it had sent us. This expansion also allows
Asterisk
    to appropriately handle an INVITE with authorization credentials if
Asterisk
    had not received an ACK from the previous transaction in which
Asterisk had
    responded to an unauthorized INVITE with a 407.
    
    (closes issue https://issues.asterisk.org/view.php?id=14239)
    Reported by: klaus3000
    Patches:
          14239.patch uploaded by mmichelson (license 60)
    Tested by: klaus3000
    	  
  ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=208389 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-07-23 14:35 svnbot         Checkin                                      
2009-07-23 14:35 svnbot         Note Added: 0108139                          
======================================================================