[asterisk-bugs] [Asterisk 0015557]: [patch] Gosub() dequotes once more than Macro()

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15557 
====================================================================== 
Reported By:                rain
Assigned To:                tilghman
====================================================================== 
Project:                    Asterisk
Issue ID:                   15557
Category:                   Applications/app_stack
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           Older 1.6.0 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-07-22 15:33 CDT
Last Modified:              2009-07-23 14:22 CDT
====================================================================== 
Summary:                    [patch] Gosub() dequotes once more than Macro()
Description: 
Since Gosub started accepting "macro" arguments (before 1.6.0-beta1), it
has been dequoting arguments one more time than Macro does.

Since Gosub() is meant to supplant Macro() in 1.6 and is already used by
AEL to implement macros, this breaks compatibility with 1.4.  This behavior
also makes it impossible to fetch arguments without quotes being
interpreted, which IS possible in a Macro() call through ${ARGn}.  It also
requires an obnoxious level of quoting if you want quotes to survive all
the way to a named macro argument in AEL -- e.g.
&macro(${QUOTE(${QUOTE(${CALLERID(all)})})});

Behind the scenes, Gosub() uses AST_STANDARD_APP_ARGS, which causes
ast_app_separate_args() to eat the quotes; Macro() does its own argument
parsing.  I think the best solution is probably to make Gosub() use
non-standard argument parsing as well, but I haven't written a patch yet
since I think this warrants more discussion.

I verified that this problem exists in 1.6.0-beta1, 1.6.0.10, and 1.6.11. 
It does not exist in 1.4 because Gosub() doesn't accept extra arguments.

====================================================================== 

---------------------------------------------------------------------- 
 (0108133) rain (reporter) - 2009-07-23 14:22
 https://issues.asterisk.org/view.php?id=15557#c108133 
---------------------------------------------------------------------- 
I tested this patch against trunk and 1.6.1.1 (with a single,
inconsequential reject -- 1.6.1.1 doesn't have LOCAL_PEEK()), and it solves
my quoting problems -- thanks!

I did accidentally notice, however, that Macro() blindly searches for
commas regardless of any quoting, while Gosub() will respect any double
quote or backslash quoting that may be in place; so, for example,
Macro(a\,b,c) has 3 arguments while Gosub(foo,s,1(a\,b,c)) has 2.

Strictly speaking, this is also an incompatibility between the two, but
one I hope many fewer people are likely to be bitten by, since blind comma
parsing is a nightmare in itself (if 'CALLERID(name)=Last, First', then
passing CALLERID(all) as a macro argument is even uglier than the quote
problem.)  I wanted to point it out, though. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-07-23 14:22 rain           Note Added: 0108133                          
======================================================================