[asterisk-bugs] [Asterisk 0014434]: [patch] Dahdi does not wait for wink on outbound calls before dialing DTMF with Signalling type = em_w

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=14434 
====================================================================== 
Reported By:                araasch
Assigned To:                jpeeler
====================================================================== 
Project:                    Asterisk
Issue ID:                   14434
Category:                   Channels/chan_dahdi
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     closed
Asterisk Version:           1.6.0.5 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-02-08 15:18 CST
Last Modified:              2009-07-21 15:27 CDT
====================================================================== 
Summary:                    [patch] Dahdi does not wait for wink on outbound
calls before dialing DTMF with Signalling type = em_w
Description: 
No provision for proper handling of the E&M wink start protocol exists in
chan_dahdi.c for outbound dialing from Asterisk.  The switch statement in
chan_dahdi.c lines 1950 and 1951 treat signalling types SIG_EMWINK and
SIG_EM exactly the same.

Asterisk should first take the channel offhook, wait for a wink from the
far end, then dial.

As it is, it takes the channel offhook, and immediately dials.

This is correct for E&M Immediate Start, but not for E&M Wink Start.

This was first reported 2005-03-15 with tracker id of 3772 which described
the problem in chan_zap.c

It appears no further action was taken.

This behavior has been verified with T1 test equipment.

I checked the code on the online Doxygen system to determine if any
further updates had addressed this issue, and it appears that none has.

Thanks.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0003772 chan_zap does not wait for wink on E&am...
====================================================================== 

---------------------------------------------------------------------- 
 (0108049) svnbot (reporter) - 2009-07-21 15:27
 https://issues.asterisk.org/view.php?id=14434#c108049 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 207860

_U  branches/1.6.0/
U   branches/1.6.0/channels/chan_dahdi.c

------------------------------------------------------------------------
r207860 | jpeeler | 2009-07-21 15:27:50 -0500 (Tue, 21 Jul 2009) | 23
lines

Merged revisions 207854 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

................
  r207854 | jpeeler | 2009-07-21 15:26:02 -0500 (Tue, 21 Jul 2009) | 16
lines
  
  Merged revisions 207827 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r207827 | jpeeler | 2009-07-21 15:16:55 -0500 (Tue, 21 Jul 2009) | 9
lines
    
    Wait for wink before dialing when using E&M wink signaling
    
    There was already code for other signaling types in dahdi_handle_event
to
    handle dialing if a dial operation dial string was present. Simply add
    SIG_EMWINK to the list.
    
    (closes issue https://issues.asterisk.org/view.php?id=14434)
    Reported by: araasch
  ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=207860 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-07-21 15:27 svnbot         Checkin                                      
2009-07-21 15:27 svnbot         Note Added: 0108049                          
======================================================================