[asterisk-bugs] [Asterisk 0012434]: Handle wrong at offer/answer in sdp in media description(m=)

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=12434 
====================================================================== 
Reported By:                mnnojd
Assigned To:                mmichelson
====================================================================== 
Project:                    Asterisk
Issue ID:                   12434
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Target Version:             1.6.0.12
Asterisk Version:           SVN 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2008-04-14 03:08 CDT
Last Modified:              2009-07-20 15:02 CDT
====================================================================== 
Summary:                    Handle wrong at offer/answer in sdp in media
description(m=)
Description: 
Asterisk answering sdp is not correct in some cases.

If settings in Asterisk is to use only audio. And then if a client have
audio and video. I have seen that Asterisk do not answer correct in sdp in
media description (m=). If there is some medias which Asterisk can not
handle it should answer with the media and set port to 0. Today Asterisk
answer only with the medias this is set to use.

I have seen this problem on Asterisk 1.6.0-beta7.1.



====================================================================== 

---------------------------------------------------------------------- 
 (0107990) svnbot (reporter) - 2009-07-20 15:02
 https://issues.asterisk.org/view.php?id=12434#c107990 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 207426

_U  branches/1.6.1/
U   branches/1.6.1/channels/chan_sip.c

------------------------------------------------------------------------
r207426 | mmichelson | 2009-07-20 15:02:06 -0500 (Mon, 20 Jul 2009) | 46
lines

Merged revisions 207424 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

................
  r207424 | mmichelson | 2009-07-20 14:48:12 -0500 (Mon, 20 Jul 2009) | 39
lines
  
  Merged revisions 207423 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r207423 | mmichelson | 2009-07-20 14:39:59 -0500 (Mon, 20 Jul 2009) |
33 lines
    
    Answer video SDP offers properly when videosupport is not enabled.
    
    Copied from Review board:
    
    In issue 12434, the reporter describes a situation in which audio and
video 
    is offered on the call, but because videosupport is disabled in
sip.conf, 
    Asterisk gives no response at all to the video offer. According to RFC
3264, 
    all media offers should have a corresponding answer. For offers we do
not 
    intend to actually reply to with meaningful values, we should still
reply 
    with the port for the media stream set to 0.
    
    In this patch, we take note of what types of media have been offered
and 
    save the information on the sip_pvt. The SDP in the response will take
into 
    account whether media was offered. If we are not otherwise going to
answer 
    a media offer, we will insert an appropriate m= line with the port set
to 0.
    
    It is important to note that this patch is pretty much a bandage being

    applied to a broken bone. The patch *only* helps for situations where
video 
    is offered but videosupport is disabled and when udptl_pt is disabled
but 
    T.38 is offered. Asterisk is not guaranteed to respond to every media
offer. 
    Notable cases are when multiple streams of the same type are offered. 
    The 2 media stream limit is still present with this patch, too.
    
    In trunk and the 1.6.X branches, things will be a bit different since
Asterisk 
    also supports text in SDPs as well.
    
    (closes issue https://issues.asterisk.org/view.php?id=12434)
    Reported by: mnnojd
    
    Review: https://reviewboard.asterisk.org/r/311
    Review: https://reviewboard.asterisk.org/r/313
  ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=207426 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-07-20 15:02 svnbot         Checkin                                      
2009-07-20 15:02 svnbot         Note Added: 0107990                          
======================================================================