[asterisk-bugs] [Asterisk 0014331]: [patch] reg->username is parsed for each registration refresh rather than once on sip reload

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=14331 
====================================================================== 
Reported By:                Nick_Lewis
Assigned To:                dvossel
====================================================================== 
Project:                    Asterisk
Issue ID:                   14331
Category:                   Channels/chan_sip/Registration
Reproducibility:            always
Severity:                   tweak
Priority:                   normal
Status:                     feedback
Asterisk Version:           1.6.1-beta4 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-01-26 06:19 CST
Last Modified:              2009-07-20 04:38 CDT
====================================================================== 
Summary:                    [patch] reg->username is parsed for each
registration refresh rather than once on sip reload
Description: 
The registration string can contain an expanded user portion of the form
user at domain (and possibly user at domain:domainport). This expanded user
portion is currently stored in reg->username and parsed each time there is
a registration refresh. It would be better if the configuration was parsed
only once and the sip_registry structure contained the atomic fields
separately through the addition of, for example, reg->regdomain and
reg->regdomainport elements
====================================================================== 

---------------------------------------------------------------------- 
 (0107947) Nick_Lewis (reporter) - 2009-07-20 04:38
 https://issues.asterisk.org/view.php?id=14331#c107947 
---------------------------------------------------------------------- 
>The sip_pvt's fromdomain field used to be set before this
When before this point in the registration process was p->fromdomain set?

>why was this taken out?
Fromdomain was never relevant to sip registrations as the from-header must
contain the same as the to-header. Previously p->fromdomain was used as a
convenient but abused container for the dynamically parsed regdomain. Now
that the regdomain has its proper place in the sip_registry this is not
necessary

>This changes the way the addr field is built
Yes it may change the behaviour of the addr field (i.e. the request line).
However I am confident that the behaviour in the patch is correct. If the
asterisk registration string contains myself at sip.me.net@registrar.me.net
then the from- and to-headers should contain myself at sip.me.net but the
request line should contain registrar.me.net

I am sorry that I incorrectly described the patch as just a tweak. I had
forgotten about this fix to the addr field. Do you want me to resubmit the
patch to include the existing addr field bug and then submit a separate bug
report with a patch to fix it? 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-07-20 04:38 Nick_Lewis     Note Added: 0107947                          
======================================================================