[asterisk-bugs] [DAHDI-linux 0015408]: [patch] Incorrect timing source validation (related to #13954)

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15408 
====================================================================== 
Reported By:                dferrer
Assigned To:                
====================================================================== 
Project:                    DAHDI-linux
Issue ID:                   15408
Category:                   tor2
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
====================================================================== 
Date Submitted:             2009-06-26 11:32 CDT
Last Modified:              2009-07-19 10:45 CDT
====================================================================== 
Summary:                    [patch] Incorrect timing source validation (related
to https://issues.asterisk.org/view.php?id=13954)
Description: 
Can't set a 4th timing source with tor2, dahdi_cfg fails with this error in
dmesg:

tor2 4: invalid span timing value 4.

This is because a '>=' comparison between lc->sync and SPANS_PER_CARD
(lc->sync = 4, SPANS_PER_CARD = 4). Comparison must be '>' strict to allow
a 4th timing source (SPANS_PER_CARD = 4). 

This commit was added to correct timing source problems and adds the
mentioned '>=' comparison:
r5590 | tzafrir | 2008-12-19 06:39:26 -0600 (Fri, 19 Dec 2008) | 4 lines

Related to https://issues.asterisk.org/view.php?id=13954

====================================================================== 

---------------------------------------------------------------------- 
 (0107937) svnbot (reporter) - 2009-07-19 10:45
 https://issues.asterisk.org/view.php?id=15408#c107937 
---------------------------------------------------------------------- 
Repository: dahdi
Revision: 6852

U   linux/trunk/drivers/dahdi/tor2.c

------------------------------------------------------------------------
r6852 | tzafrir | 2009-07-19 10:45:43 -0500 (Sun, 19 Jul 2009) | 12 lines

tor2: allow using port4 as timing source

Fix a silly regression introduced when strict check on the timing
parameter was added (sync-1 is the array index, not sync itself. And 0
is a special case).

(closes issue https://issues.asterisk.org/view.php?id=15408)
Reported by: dferrer
Patches:
      tor2-4th_sync.patch uploaded by dferrer (license 525)


------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=6852 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-07-19 10:45 svnbot         Checkin                                      
2009-07-19 10:45 svnbot         Note Added: 0107937                          
======================================================================