[asterisk-bugs] [Asterisk 0015376]: SIP option (SIP_OPT_ flag) is not handled correctly

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15376 
====================================================================== 
Reported By:                Takehiko Ooshima
Assigned To:                dvossel
====================================================================== 
Project:                    Asterisk
Issue ID:                   15376
Category:                   Channels/chan_sip/General
Reproducibility:            have not tried
Severity:                   minor
Priority:                   normal
Status:                     closed
Target Version:             1.6.0.12
Asterisk Version:           1.6.1.1 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-06-22 07:52 CDT
Last Modified:              2009-07-17 12:53 CDT
====================================================================== 
Summary:                    SIP option (SIP_OPT_ flag) is not handled correctly
Description: 
chan_sip.c
 SIP Options (required_profile, p->sipoptions, and so on) compare must
bit-field.
 But 1.6.1.0 or 1.6.1.1 source compare entire flag value.

for example
1.6.1.1/channels/chan_sip.c: 18202
-  if (p->sipoptions == SIP_OPT_TIMER) {
+  if (p->sipoptions & SIP_OPT_TIMER) {

So, our PBX: SIP_OPT_TIMER & SIP_OPT_REPLACE (== 5) not much SIP_OPT_TIMER
routine.
====================================================================== 

---------------------------------------------------------------------- 
 (0107910) svnbot (reporter) - 2009-07-17 12:53
 https://issues.asterisk.org/view.php?id=15376#c107910 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 207032

_U  branches/1.6.0/
U   branches/1.6.0/channels/chan_sip.c

------------------------------------------------------------------------
r207032 | dvossel | 2009-07-17 12:53:51 -0500 (Fri, 17 Jul 2009) | 13
lines

Merged revisions 207029 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

........
  r207029 | dvossel | 2009-07-17 12:51:44 -0500 (Fri, 17 Jul 2009) | 6
lines
  
  sip option flags handled incorrectly
  
  (closes issue https://issues.asterisk.org/view.php?id=15376)
  Reported by: Takehiko Ooshima
  Tested by: dvossel, Takehiko_Ooshima
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=207032 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-07-17 12:53 svnbot         Checkin                                      
2009-07-17 12:53 svnbot         Note Added: 0107910                          
======================================================================