[asterisk-bugs] [Asterisk 0015376]: SIP option (SIP_OPT_ flag) is not handled correctly

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15376 
====================================================================== 
Reported By:                Takehiko Ooshima
Assigned To:                dvossel
====================================================================== 
Project:                    Asterisk
Issue ID:                   15376
Category:                   Channels/chan_sip/General
Reproducibility:            have not tried
Severity:                   minor
Priority:                   normal
Status:                     assigned
Target Version:             1.6.0.12
Asterisk Version:           1.6.1.1 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-06-22 07:52 CDT
Last Modified:              2009-07-17 12:33 CDT
====================================================================== 
Summary:                    SIP option (SIP_OPT_ flag) is not handled correctly
Description: 
chan_sip.c
 SIP Options (required_profile, p->sipoptions, and so on) compare must
bit-field.
 But 1.6.1.0 or 1.6.1.1 source compare entire flag value.

for example
1.6.1.1/channels/chan_sip.c: 18202
-  if (p->sipoptions == SIP_OPT_TIMER) {
+  if (p->sipoptions & SIP_OPT_TIMER) {

So, our PBX: SIP_OPT_TIMER & SIP_OPT_REPLACE (== 5) not much SIP_OPT_TIMER
routine.
====================================================================== 

---------------------------------------------------------------------- 
 (0107906) dvossel (administrator) - 2009-07-17 12:33
 https://issues.asterisk.org/view.php?id=15376#c107906 
---------------------------------------------------------------------- 
shouldn't it be 

if (required_profile && !(required_profile & (SIP_OPT_REPLACES |
SIP_OPT_TIMER))) 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-07-17 12:33 dvossel        Note Added: 0107906                          
======================================================================