[asterisk-bugs] [Asterisk 0014331]: [patch] reg->username is parsed for each registration refresh rather than once on sip reload

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=14331 
====================================================================== 
Reported By:                Nick_Lewis
Assigned To:                dvossel
====================================================================== 
Project:                    Asterisk
Issue ID:                   14331
Category:                   Channels/chan_sip/Registration
Reproducibility:            always
Severity:                   tweak
Priority:                   normal
Status:                     feedback
Asterisk Version:           1.6.1-beta4 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-01-26 06:19 CST
Last Modified:              2009-07-17 11:48 CDT
====================================================================== 
Summary:                    [patch] reg->username is parsed for each
registration refresh rather than once on sip reload
Description: 
The registration string can contain an expanded user portion of the form
user at domain (and possibly user at domain:domainport). This expanded user
portion is currently stored in reg->username and parsed each time there is
a registration refresh. It would be better if the configuration was parsed
only once and the sip_registry structure contained the atomic fields
separately through the addition of, for example, reg->regdomain and
reg->regdomainport elements
====================================================================== 

---------------------------------------------------------------------- 
 (0107899) dvossel (administrator) - 2009-07-17 11:48
 https://issues.asterisk.org/view.php?id=14331#c107899 
---------------------------------------------------------------------- 
-		/* If the registration username contains '@', then the domain should be
used as
-		   the equivalent of "fromdomain" for the registration */
-		if (ast_strlen_zero(p->fromdomain)) {
-			ast_string_field_set(p, fromdomain, fromdomain);
-		}


The sip_pvt's fromdomain field used to be set before this, why was this
taken out?  I don't fully understand the implications of this.


-	/* Fromdomain is what we are registering to, regardless of actual
	   host name from SRV */
+	/* Host is what we are registering to, regardless of domain */

This changes the way the addr field is built.  It used to be created using
fromdomain, which was the user at domain:port part of the uri, if it was
present.  Now it is built using the hostname only.  I haven't researched
the importance of this, all I am doing is trying to verify no behavior
changes are present in this patch.

Thanks for the update! 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-07-17 11:48 dvossel        Note Added: 0107899                          
======================================================================